From patchwork Thu Jan 2 12:59:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 37156 Received: (qmail 99807 invoked by alias); 2 Jan 2020 13:00:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 97294 invoked by uid 89); 2 Jan 2020 13:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-pl1-f193.google.com Received: from mail-pl1-f193.google.com (HELO mail-pl1-f193.google.com) (209.85.214.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Jan 2020 13:00:20 +0000 Received: by mail-pl1-f193.google.com with SMTP id c23so17799580plz.4 for ; Thu, 02 Jan 2020 05:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=FtnMRN9BSgyRdZvK0rFv9oCeo10x8YTXLQzHEY9YBD8=; b=iJaJiGenYsZgK6MfjqDDk8by/2XMa/EMC9yIuT0FlKaRDS2qYcAw8pVDT6vRR5Abng +hCUhlRjQzPyPDX6ak6S04SnSKCu48PENBNnykIRVCFWT/k7fXTXtBIxAU4orU2XwubY ENI7Ca/dTZiZTB4eivJg+kIMsIzsapBD2gchwDv4h1j27CrZwsZUAoCzyVNo2yy8WIzF 9oOYXjEKwdcyQHxz2ilSMCFSgXT78Ncc3+TRrB8a0e4DyBGU5Quq1tIIOfYqfL2Xu40B BgBuuc5eVi4txucJOHsaX18AfEAfKE+tk3cCzXiJQ215zbkhW7tbXTPBt2a7wimpcd3G qoeA== Return-Path: Received: from localhost.localdomain ([191.34.95.6]) by smtp.gmail.com with ESMTPSA id 12sm64672887pfn.177.2020.01.02.05.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 05:00:04 -0800 (PST) From: Luis Machado To: gdb-patches@sourceware.org, simark@simark.ca Subject: [PATCH, v2] Remove stale references to Cell BE Date: Thu, 2 Jan 2020 09:59:58 -0300 Message-Id: <20200102125958.762-1-luis.machado@linaro.org> In-Reply-To: <20191230185036.26435-1-luis.machado@linaro.org> References: <20191230185036.26435-1-luis.machado@linaro.org> X-IsSubscribed: yes Updated the comment. How does it look now? --- While reading some code i noticed we're still referencing Cell BE in a couple parts. This patch removes those. v2: Update comment in gdb/target.h. gdb/ChangeLog: 2020-01-02 Luis Machado * proc-service.c (get_ps_regcache): Remove reference to obsolete Cell BE architecture. * target.h (struct target_ops) : Likewise. Change-Id: I7a9ccc603b00db22a6275bc5ab69e1417148cb72 --- gdb/proc-service.c | 5 +---- gdb/target.h | 9 ++++----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/gdb/proc-service.c b/gdb/proc-service.c index b0741318ad..75ad126472 100644 --- a/gdb/proc-service.c +++ b/gdb/proc-service.c @@ -129,10 +129,7 @@ ps_pdwrite (struct ps_prochandle *ph, psaddr_t addr, /* Get a regcache for LWPID using its inferior's "main" architecture, which is the register set libthread_db expects to be using. In multi-arch debugging scenarios, the thread's architecture may - differ from the inferior's "main" architecture. E.g., in the Cell - combined debugger, if GDB happens to interrupt SPU code, the - thread's architecture is SPU, and the main architecture is - PowerPC. */ + differ from the inferior's "main" architecture. */ static struct regcache * get_ps_regcache (struct ps_prochandle *ph, lwpid_t lwpid) diff --git a/gdb/target.h b/gdb/target.h index 1bb7276673..42d079da53 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -878,11 +878,10 @@ struct target_ops /* Determine current architecture of thread PTID. The target is supposed to determine the architecture of the code where - the target is currently stopped at (on Cell, if a target is in spu_run, - to_thread_architecture would return SPU, otherwise PPC32 or PPC64). - This is architecture used to perform decr_pc_after_break adjustment, - and also determines the frame architecture of the innermost frame. - ptrace operations need to operate according to target_gdbarch (). */ + the target is currently stopped at. The architecture information is + used to perform decr_pc_after_break adjustment, and also to determine + the frame architecture of the innermost frame. ptrace operations need to + operate according to target_gdbarch (). */ virtual struct gdbarch *thread_architecture (ptid_t) TARGET_DEFAULT_RETURN (NULL);