From patchwork Thu Nov 28 20:08:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Waroquiers X-Patchwork-Id: 36363 Received: (qmail 28456 invoked by alias); 28 Nov 2019 20:09:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 28402 invoked by uid 89); 28 Nov 2019 20:09:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=U*philippe.waroquiers, D*skynet.be, philippe.waroquiers@skynet.be, D*be X-HELO: mailsec106.isp.belgacom.be Received: from mailsec106.isp.belgacom.be (HELO mailsec106.isp.belgacom.be) (195.238.20.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2019 20:09:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1574971756; x=1606507756; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xj3oaRXS0+AmB9ALXBKe4KqXEZSaR4WKprAw9vQWmRU=; b=bYwm2dip9GuCbVXfurfHjxH8U35Jp7CEFqU+o/w4MdwitIrxzGgo4vdG QsGRsvHAQP8UPFYyFAsu5EAYMsUyQw==; IronPort-SDR: tX5kWMJO9+DSH8UsWUcSr8991UlFC+VVsETIUANz7mymf3cr/ojXz34iOiFoQSQsLp6YLdRPLn EnUOc2ZUxgHla0lAZZjE8pk8Kl8gU3im+CsYUDDUOS9wXWEo6CjwIMLrNNrJAAuLJf7ku03Hff BfThAcYDJdq+4o53ideQMmrr2QWLmrPF4vZssz8DMMwUezkbD6ICtKziEMoG9kCo/nC3Ennmfn RG70CwUpHpgaLdP0dKPiwralGeV+0eg4QWyzkJzDo7Cu+BVKTQxb5LQD+r8izsLQcSYQa8N2sd TbQ= Received: from 136.173-134-109.adsl-dyn.isp.belgacom.be (HELO md.home) ([109.134.173.136]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2019 21:09:08 +0100 From: Philippe Waroquiers To: gdb-patches@sourceware.org Cc: Philippe Waroquiers Subject: [RFAv3 2/4] Test define-prefix. Date: Thu, 28 Nov 2019 21:08:59 +0100 Message-Id: <20191128200901.27511-3-philippe.waroquiers@skynet.be> In-Reply-To: <20191128200901.27511-1-philippe.waroquiers@skynet.be> References: <20191128200901.27511-1-philippe.waroquiers@skynet.be> MIME-Version: 1.0 X-IsSubscribed: yes Adds a test testing the new define-prefix command. 2019-11-27 Philippe Waroquiers * gdb.base/define-prefix.exp: New file. --- gdb/testsuite/gdb.base/define-prefix.exp | 164 +++++++++++++++++++++++ 1 file changed, 164 insertions(+) create mode 100644 gdb/testsuite/gdb.base/define-prefix.exp diff --git a/gdb/testsuite/gdb.base/define-prefix.exp b/gdb/testsuite/gdb.base/define-prefix.exp new file mode 100644 index 0000000000..b04c5959c0 --- /dev/null +++ b/gdb/testsuite/gdb.base/define-prefix.exp @@ -0,0 +1,164 @@ +# This testcase is part of GDB, the GNU debugger. + +# Copyright 2019 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + + +# This test verifies the "define-prefix" command. + +gdb_start + +#################### +# Verify the definition of user defined prefix commands. +# Test the definition of a command using these prefixes. + +# Define an empty prefix command. +gdb_test_no_output "define-prefix abc-prefix" + +# Verify an empty prefix command cannot be used as a command. +gdb_test "abc-prefix" \ + "\"abc-prefix\" must be followed by the name of a subcommand.*" \ + "execute prefix command not followed by subcommand" + +# Define a sub-prefix command. +gdb_test_no_output "define-prefix abc-prefix def-prefix" + +# Define ghi-cmd using the prefixes. +gdb_test_multiple "define abc-prefix def-prefix ghi-cmd" \ + "define user command: abc-prefix def-prefix ghi-cmd" { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + gdb_test "echo command ghi-cmd\\n\nend" "" \ + "define user command: ghi-cmd" + } + } +# Verify ghi-cmd works. +gdb_test "abc-prefix def-prefix ghi-cmd" \ + "command ghi-cmd" \ + "use user command: ghi-cmd" + + +#################### +# Verify an existing (empty) command can be marked as a prefix command. +# Then verify an empty prefix command can be transformed into an executable command. + +# Define ghi-prefix-cmd as an empty command. +gdb_test_multiple "define abc-prefix def-prefix ghi-prefix-cmd" \ + "define user command: abc-prefix def-prefix ghi-prefix-cmd" { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-prefix-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + gdb_test "end" "" \ + "define user command: ghi-prefix-cmd" + } + } +gdb_test_no_output "define-prefix abc-prefix def-prefix ghi-prefix-cmd" + +# Verify a sequence ending with an empty prefix command cannot be used as +# a command. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd" \ + "\"abc-prefix def-prefix ghi-prefix-cmd\" must be followed by the name of a subcommand.*" \ + "execute sequence of prefix commands not followed by a subcommand" + +# Define jkl-cmd command. +gdb_test_multiple "define abc-prefix def-prefix ghi-prefix-cmd jkl-cmd" \ + "define user command: abc-prefix def-prefix ghi-prefix-cmd jkl-cmd" { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-prefix-cmd jkl-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + gdb_test "echo command jkl-cmd\\n\nend" "" \ + "define user command: jkl-cmd" + } + } +# Verify jkl-cmd command works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd jkl-cmd" \ + "command jkl-cmd" \ + "use user command: jkl-cmd" + +# Define alternate-jkl-cmd and check it works. +# Define alternate-jkl-cmd command. +gdb_test_multiple "define abc-prefix def-prefix ghi-prefix-cmd alternate-jkl-cmd" \ + "define user command: abc-prefix def-prefix ghi-prefix-cmd alternate-jkl-cmd" { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-prefix-cmd alternate-jkl-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + gdb_test "echo command alternate-jkl-cmd\\n\nend" "" \ + "define user command: alternate-jkl-cmd" + } + } +# Verify alternate-jkl-cmd command works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd alternate-jkl-cmd" \ + "command alternate-jkl-cmd" \ + "use user command: alternate-jkl-cmd" + + + +# Now define ghi-prefix-cmd as a real command, and check it is working. +send_gdb "define abc-prefix def-prefix ghi-prefix-cmd\n" +gdb_expect { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-prefix-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + send_gdb "echo defined command ghi-prefix-cmd\\n\nend\n" + gdb_expect { + -re "$gdb_prompt $" {pass "define user command: ghi-prefix-cmd"} + timeout {fail "(timeout) define user command: ghi-prefix-cmd"} + } + } + timeout {fail "(timeout) define user command: ghi-prefix-cmd"} +} + +# Verify ghi-prefix-cmd command works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd" \ + "defined command ghi-prefix-cmd" \ + "use defined user command: ghi-prefix-cmd" + +# Now redefine ghi-prefix-cmd, and check it is working. +send_gdb "define abc-prefix def-prefix ghi-prefix-cmd\n" +gdb_expect { + -re "Keeping subcommands of prefix command \"ghi-prefix-cmd\"\.\r\nRedefine command \"ghi-prefix-cmd\".*y or n. $" { + send_gdb "y\n" + gdb_expect { + -re "Type commands for definition of \"abc-prefix def-prefix ghi-prefix-cmd\".\r\nEnd with a line saying just \"end\".\r\n>$" { + send_gdb "echo redefined command ghi-prefix-cmd\\n\nend\n" + gdb_expect { + -re "$gdb_prompt $" {pass "redefine user command: ghi-prefix-cmd"} + timeout {fail "(timeout) redefine user command: ghi-prefix-cmd"} + } + } + timeout {fail "(timeout) redefine user command: ghi-prefix-cmd"} + } + } + -re "$gdb_prompt $" {fail "redefine user command: ghi-prefix-cmd"} + timeout {fail "(timeout) redefine user command: ghi-prefix-cmd"} +} + +# Verify redefined ghi-prefix-cmd command works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd" \ + "redefined command ghi-prefix-cmd" \ + "use redefined user command: ghi-prefix-cmd" + +# Check jkl-cmd still works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd jkl-cmd" \ + "command jkl-cmd" \ + "use user command after redefining ghi-prefix-cmd: jkl-cmd" + +# Check alternate-jkl-cmd still works. +gdb_test "abc-prefix def-prefix ghi-prefix-cmd alternate-jkl-cmd" \ + "command alternate-jkl-cmd" \ + "use user command after redefining ghi-prefix-cmd: alternate-jkl-cmd" + +#################### +# Check error behaviour. + +gdb_test "define-prefix print" ".* is built-in.*" + +gdb_test "define-prefix something-not-existing something-else" \ + "Undefined command: \"something-not-existing\".*" + +gdb_test "define-prefix abc-prefix something-not-existing something-else" \ + "Undefined abc-prefix command: \"something-not-existing\".*" +