diff mbox

Add missing parentheses on 'print' (gdb.python/py-progspace.exp)

Message ID 20191120213513.29706-1-sergiodj@redhat.com
State New, archived
Headers

Commit Message

Sergio Durigan Junior Nov. 20, 2019, 9:35 p.m. UTC 
  Commit 33d569b709886a1208145806da80b689d9cae9da ("gdb/python: Return
None from Progspace.block_for_pc on error") added a few tests on
gdb.python/py-progspace.exp which use 'print', but forgot to use
parentheses when passing the arguments to be printed.  This fails on
Python 3.

This commit adds these missing parentheses.  Pushed as obvious.

gdb/testsuite/ChangeLog:
2019-11-20  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.python/py-progspace.exp: Add missing parentheses on some
	'print' commands.

Change-Id: Iac0a7578855d128bbee3b98e7ea5888dae55fc00
---
 gdb/testsuite/ChangeLog                   | 5 +++++
 gdb/testsuite/gdb.python/py-progspace.exp | 6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 32dc308332..f47ed172a6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-11-20  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* gdb.python/py-progspace.exp: Add missing parentheses on some
+	'print' commands.
+
 2019-11-19  Tom Tromey  <tom@tromey.com>
 
 	* gdb.tui/winheight.exp: New file.
diff --git a/gdb/testsuite/gdb.python/py-progspace.exp b/gdb/testsuite/gdb.python/py-progspace.exp
index d1bcb81bb4..46194412fb 100644
--- a/gdb/testsuite/gdb.python/py-progspace.exp
+++ b/gdb/testsuite/gdb.python/py-progspace.exp
@@ -61,14 +61,14 @@  if {![runto_main]} {
 set pc_val [get_integer_valueof "\$pc" 0]
 gdb_py_test_silent_cmd "python blk = gdb.current_progspace ().block_for_pc (${pc_val})" \
     "get block for the current \$pc" 1
-gdb_test "python print blk.start <= ${pc_val}" "True" \
+gdb_test "python print (blk.start <= ${pc_val})" "True" \
     "block start is before \$pc"
-gdb_test "python print blk.end >= ${pc_val}" "True" \
+gdb_test "python print (blk.end >= ${pc_val})" "True" \
     "block end is after \$pc"
 
 # Check what happens when we ask for a block of an invalid address.
 if ![is_address_zero_readable] {
-    gdb_test "python print gdb.current_progspace ().block_for_pc (0)" "None"
+    gdb_test "python print (gdb.current_progspace ().block_for_pc (0))" "None"
 }
 
 # With a single inferior, progspace.objfiles () and gdb.objfiles () should