From patchwork Wed Oct 23 19:15:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 35265 Received: (qmail 16216 invoked by alias); 23 Oct 2019 19:15:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 16150 invoked by uid 89); 23 Oct 2019 19:15:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.128.65, H*RU:209.85.128.65 X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2019 19:15:31 +0000 Received: by mail-wm1-f65.google.com with SMTP id v3so355647wmh.1 for ; Wed, 23 Oct 2019 12:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QNIT2hMAWhKPQhhClQX5nCo6oVlrGtZtysrNGkIGhn8=; b=fNway//1gz6gCg/pNGv5Gt2Pw8jbXqOorMm+qm4czlVh5a3tYHjsnq39Djopw+Zw3M ql6Eb73UTu5JhRHABC1bjO99RpTyqXM2hm7VtY9x+aJG9EqItdpm2olwfulOpjsSVGoo eTM4AbiGIVt5SGvQ772YjPFumrstpk3HE6cx0Ud5Ivl2zSjVwr/6y+JjOzOmpKwozmIR APZxbpm3lNEmsvbkBAAT7A166he/rfcRGP2sDE8JCBb8MBx/dIzVT3Tsr6H3iu/tFWrB 8e9gvoD0o9CqAbbSeLiLo+8oHnQo8yFjIkUU7TeoiJOJETiOr/3Ebwmy71Gclsm9j8Rc xmYQ== Return-Path: Received: from localhost (host86-128-12-122.range86-128.btcentralplus.com. [86.128.12.122]) by smtp.gmail.com with ESMTPSA id c18sm20469791wrv.10.2019.10.23.12.15.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 12:15:28 -0700 (PDT) Date: Wed, 23 Oct 2019 20:15:28 +0100 From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org, cbiesinger@google.com Subject: Re: [PATCH] gdb/python: Introduce gdb.lookup_all_static_symbols Message-ID: <20191023191528.GI4962@embecosm.com> References: <20191015141515.GW4962@embecosm.com> <20191015164647.1837-1-andrew.burgess@embecosm.com> <83pniyey3m.fsf@gnu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83pniyey3m.fsf@gnu.org> X-Fortune: Stability itself is nothing else than a more sluggish motion. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes * Eli Zaretskii [2019-10-15 20:07:41 +0300]: > > From: Andrew Burgess > > Cc: Christian Biesinger , Andrew Burgess > > Date: Tue, 15 Oct 2019 17:46:47 +0100 > > > > gdb/ChangeLog: > > > > * python/py-symbol.c (gdbpy_lookup_all_static_symbols): New > > function. > > * python/python-internal.h (gdbpy_lookup_all_static_symbols): > > Declare new function. > > * python/python.c (python_GdbMethods): Add > > gdb.lookup_all_static_symbols method. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.python/py-symbol.exp: Add test for > > gdb.lookup_all_static_symbols. > > > > gdb/doc/ChangeLog: > > > > * python.texi (Symbols In Python): Add documentation for > > gdb.lookup_all_static_symbols. > > The python.texi part is OK, but I think this change also needs a NEWS > entry. Thanks for the review, I'll include the NEWS entry below when I merge this patch. Thanks, Andrew diff --git a/gdb/NEWS b/gdb/NEWS index 25e67e43c88..465f96aed18 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -65,6 +65,9 @@ ** The new function gdb.lookup_static_symbol can be used to look up symbols with static linkage. + ** The new function gdb.lookup_static_symbols can be used to look up + all static symbols with static linkage. + ** gdb.Objfile has new methods 'lookup_global_symbol' and 'lookup_static_symbol' to lookup a symbol from this objfile only.