From patchwork Mon Oct 14 16:15:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34946 Received: (qmail 123814 invoked by alias); 14 Oct 2019 16:15:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123446 invoked by uid 89); 14 Oct 2019 16:15:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=th, suspended, HANDLE X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 16:15:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C977156046; Mon, 14 Oct 2019 12:15:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id M9p3ICaGQsWQ; Mon, 14 Oct 2019 12:15:22 -0400 (EDT) Received: from murgatroyd.Home (174-29-53-230.hlrn.qwest.net [174.29.53.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 757A156043; Mon, 14 Oct 2019 12:15:22 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/9] Remove the "next" field from windows_thread_info Date: Mon, 14 Oct 2019 10:15:12 -0600 Message-Id: <20191014161520.13150-2-tromey@adacore.com> In-Reply-To: <20191014161520.13150-1-tromey@adacore.com> References: <20191014161520.13150-1-tromey@adacore.com> MIME-Version: 1.0 This changes windows_thread_info to remove the "next" field, replacing the linked list of threads with a vector. This is a prerequisite to sharing is structure with gdbserver, which manages threads differently. gdb/ChangeLog 2019-10-14 Tom Tromey * windows-nat.c (struct windows_thread_info): Remove typedef. (thread_head): Remove. (thread_list): New global. (thread_rec, windows_add_thread, windows_init_thread_list) (windows_delete_thread, windows_continue): Update. --- gdb/ChangeLog | 8 ++++++++ gdb/windows-nat.c | 52 +++++++++++++++++++---------------------------- 2 files changed, 29 insertions(+), 31 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 607b2e8cb97..d3413a3e319 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -43,6 +43,7 @@ #include #endif #include +#include #include "filenames.h" #include "symfile.h" @@ -214,9 +215,8 @@ static enum gdb_signal last_sig = GDB_SIGNAL_0; /* Thread information structure used to track information that is not available in gdb's thread structure. */ -typedef struct windows_thread_info_struct +struct windows_thread_info { - struct windows_thread_info_struct *next; DWORD id; HANDLE h; CORE_ADDR thread_local_base; @@ -224,10 +224,9 @@ typedef struct windows_thread_info_struct int suspended; int reload_context; CONTEXT context; - } -windows_thread_info; + }; -static windows_thread_info thread_head; +static std::vector thread_list; /* The process and thread handles for the above context. */ @@ -384,9 +383,7 @@ check (BOOL ok, const char *file, int line) static windows_thread_info * thread_rec (DWORD id, int get_context) { - windows_thread_info *th; - - for (th = &thread_head; (th = th->next) != NULL;) + for (windows_thread_info *th : thread_list) if (th->id == id) { if (!th->suspended && get_context) @@ -448,8 +445,7 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, bool main_thread_p) th->id = id; th->h = h; th->thread_local_base = (CORE_ADDR) (uintptr_t) tlb; - th->next = thread_head.next; - thread_head.next = th; + thread_list.push_back (th); /* Add this new thread to the list of threads. @@ -484,17 +480,13 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, bool main_thread_p) static void windows_init_thread_list (void) { - windows_thread_info *th = &thread_head; - DEBUG_EVENTS (("gdb: windows_init_thread_list\n")); init_thread_list (); - while (th->next != NULL) - { - windows_thread_info *here = th->next; - th->next = here->next; - xfree (here); - } - thread_head.next = NULL; + + for (windows_thread_info *here : thread_list) + xfree (here); + + thread_list.clear (); } /* Delete a thread from the list of threads. @@ -507,7 +499,6 @@ windows_init_thread_list (void) static void windows_delete_thread (ptid_t ptid, DWORD exit_code, bool main_thread_p) { - windows_thread_info *th; DWORD id; gdb_assert (ptid.tid () != 0); @@ -530,17 +521,17 @@ windows_delete_thread (ptid_t ptid, DWORD exit_code, bool main_thread_p) delete_thread (find_thread_ptid (ptid)); - for (th = &thread_head; - th->next != NULL && th->next->id != id; - th = th->next) - continue; + auto iter = std::find_if (thread_list.begin (), thread_list.end (), + [=] (windows_thread_info *th) + { + return th->id == id; + }); - if (th->next != NULL) + if (iter != thread_list.end ()) { - windows_thread_info *here = th->next; - th->next = here->next; - xfree (here->name); - xfree (here); + xfree ((*iter)->name); + xfree (*iter); + thread_list.erase (iter); } } @@ -1319,7 +1310,6 @@ handle_exception (struct target_waitstatus *ourstatus) static BOOL windows_continue (DWORD continue_status, int id, int killed) { - windows_thread_info *th; BOOL res; DEBUG_EVENTS (("ContinueDebugEvent (cpid=%d, ctid=0x%x, %s);\n", @@ -1328,7 +1318,7 @@ windows_continue (DWORD continue_status, int id, int killed) continue_status == DBG_CONTINUE ? "DBG_CONTINUE" : "DBG_EXCEPTION_NOT_HANDLED")); - for (th = &thread_head; (th = th->next) != NULL;) + for (windows_thread_info *th : thread_list) if ((id == -1 || id == (int) th->id) && th->suspended) {