From patchwork Thu Oct 10 08:38:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 34903 Received: (qmail 116487 invoked by alias); 10 Oct 2019 08:38:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 116479 invoked by uid 89); 10 Oct 2019 08:38:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 08:38:24 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EE3E8B12D for ; Thu, 10 Oct 2019 08:38:21 +0000 (UTC) Date: Thu, 10 Oct 2019 10:38:20 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Fix regexp for reg value in jit-reader.exp Message-ID: <20191010083819.GA31962@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, On openSUSE Leap 15.1 (as well as on Fedora-x86_64-m64 buildbot) I see: ... FAIL: gdb.base/jit-reader.exp: with jit-reader: after mangling: current frame: info registers ... The problem is that r10 is printed signed: ... r10 0xffffffffffffffb0 -80^M ... but the regexp expects a signed value: ... "r10 $hex +$decimal" \ ... Fix this by allowing signed values. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Fix regexp for reg value in jit-reader.exp gdb/testsuite/ChangeLog: 2019-10-10 Tom de Vries * gdb.base/jit-reader.exp: Allow non-pointer registers to be printed as signed. --- gdb/testsuite/gdb.base/jit-reader.exp | 41 ++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index 7c07c16363d..1ef3341bd25 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -65,32 +65,33 @@ proc info_registers_current_frame {sp} { set any "\[^\r\n\]*" + set neg_decimal "-?$decimal" gdb_test "info registers" \ [multi_line \ - "rax $hex +$decimal" \ - "rbx $hex +$decimal" \ - "rcx $hex +$decimal" \ - "rdx $hex +$decimal" \ - "rsi $hex +$decimal" \ - "rdi $hex +$decimal" \ + "rax $hex +$neg_decimal" \ + "rbx $hex +$neg_decimal" \ + "rcx $hex +$neg_decimal" \ + "rdx $hex +$neg_decimal" \ + "rsi $hex +$neg_decimal" \ + "rdi $hex +$neg_decimal" \ "rbp $hex +$hex" \ "rsp $sp +$sp" \ - "r8 $hex +$decimal" \ - "r9 $hex +$decimal" \ - "r10 $hex +$decimal" \ - "r11 $hex +$decimal" \ - "r12 $hex +$decimal" \ - "r13 $hex +$decimal" \ - "r14 $hex +$decimal" \ - "r15 $hex +$decimal" \ + "r8 $hex +$neg_decimal" \ + "r9 $hex +$neg_decimal" \ + "r10 $hex +$neg_decimal" \ + "r11 $hex +$neg_decimal" \ + "r12 $hex +$neg_decimal" \ + "r13 $hex +$neg_decimal" \ + "r14 $hex +$neg_decimal" \ + "r15 $hex +$neg_decimal" \ "rip $hex +$hex$any" \ "eflags $hex +\\\[$any\\\]" \ - "cs $hex +$decimal" \ - "ss $hex +$decimal" \ - "ds $hex +$decimal" \ - "es $hex +$decimal" \ - "fs $hex +$decimal" \ - "gs $hex +$decimal" \ + "cs $hex +$neg_decimal" \ + "ss $hex +$neg_decimal" \ + "ds $hex +$neg_decimal" \ + "es $hex +$neg_decimal" \ + "fs $hex +$neg_decimal" \ + "gs $hex +$neg_decimal" \ ] }