From patchwork Tue Jun 18 14:07:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 33181 Received: (qmail 15741 invoked by alias); 18 Jun 2019 14:07:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 15733 invoked by uid 89); 18 Jun 2019 14:07:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=utils.c, UD:utils.c, utilsc X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jun 2019 14:07:45 +0000 Received: by mail-wr1-f68.google.com with SMTP id n4so6067254wrs.3 for ; Tue, 18 Jun 2019 07:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id; bh=23GCPk3BpfE076vEy4cBczAKFjlzhytRwZ3NSH8DA+A=; b=Gr3Ww0bLQtAwZTF1KIg6nCuen0ONJgjP0LyNrBj7y1qQiuTfLE5aFVuPqQH6f8tZMd R+ELotKlQyxQjl7f4Es4OnQPuVqa+tjK93xS8QFJfZ0M9Ku4uRLafJAI6FIj6u+Ux/Nw bN3+INj/tKJUAMsawjZQxYplvmxdHaw2V1YwBy01XU7e0SfuQ5Efz2p0WtY0jwzKxIt4 hrBdm7ZNe2ly2Li91YsvblURmQjcpPOWM8aoD5H97CFRRdSZYFYy7B9wTCcIYTckepRV C7IUSbQq0jC0e94UmbwWO5B/q2k4jM+sMQ6Wj+2tOsx4ovJirqmqnxdnYnNttU8CfKNy 4dkQ== Return-Path: Received: from localhost (host86-180-62-212.range86-180.btcentralplus.com. [86.180.62.212]) by smtp.gmail.com with ESMTPSA id c4sm18237470wrb.68.2019.06.18.07.07.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 07:07:42 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb: Remove use of deprecated_interactive_hook Date: Tue, 18 Jun 2019 15:07:40 +0100 Message-Id: <20190618140740.1872-1-andrew.burgess@embecosm.com> X-IsSubscribed: yes The deprecated_interactive_hook is not used within GDB. It is used in gdbtk, however this patch removes that use: https://sourceware.org/ml/insight/2019-q2/msg00001.html So I think there is no longer a reason to keep this hook around. This patch removes it. There should be no user visible changes after this commit. gdb/ChangeLog: * defs.h (deprecated_interactive_hook): Delete declaration. * interps.c (clear_interpreter_hooks): Remove use of deprecated_interactive_hook. * top.c (deprecated_interactive_hook): Delete definition. * utils.c (maybe_quit): Remove use of deprecated_interactive_hook. --- gdb/ChangeLog | 8 ++++++++ gdb/defs.h | 1 - gdb/interps.c | 1 - gdb/top.c | 5 ----- gdb/utils.c | 3 --- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index e95d0d43480..3d878c84e3f 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -600,7 +600,6 @@ extern int (*deprecated_query_hook) (const char *, va_list) ATTRIBUTE_FPTR_PRINTF(1,0); extern void (*deprecated_warning_hook) (const char *, va_list) ATTRIBUTE_FPTR_PRINTF(1,0); -extern void (*deprecated_interactive_hook) (void); extern void (*deprecated_readline_begin_hook) (const char *, ...) ATTRIBUTE_FPTR_PRINTF_1; extern char *(*deprecated_readline_hook) (const char *); diff --git a/gdb/interps.c b/gdb/interps.c index 363502e7677..3495dcb53c3 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -353,7 +353,6 @@ clear_interpreter_hooks (void) /*print_frame_more_info_hook = 0; */ deprecated_query_hook = 0; deprecated_warning_hook = 0; - deprecated_interactive_hook = 0; deprecated_readline_begin_hook = 0; deprecated_readline_hook = 0; deprecated_readline_end_hook = 0; diff --git a/gdb/top.c b/gdb/top.c index 857207c3767..be736b0a87d 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -240,11 +240,6 @@ void (*deprecated_readline_end_hook) (void); void (*deprecated_attach_hook) (void); void (*deprecated_detach_hook) (void); -/* Called during long calculations to allow GUI to repair window - damage, and to check for stop buttons, etc... */ - -void (*deprecated_interactive_hook) (void); - /* Called when going to wait for the target. Usually allows the GUI to run while waiting for target events. */ diff --git a/gdb/utils.c b/gdb/utils.c index c7922cf7f56..7120a922584 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -678,9 +678,6 @@ maybe_quit (void) quit (); quit_handler (); - - if (deprecated_interactive_hook) - deprecated_interactive_hook (); }