diff mbox

[FYI] Fix darwin-nat.c build

Message ID 20190516164721.21127-1-tromey@adacore.com
State New
Headers show

Commit Message

Tom Tromey May 16, 2019, 4:47 p.m. UTC
John Marshall pointed out that darwin-nat.c fails to build:

    CXX    darwin-nat.o
    ../../../binutils-gdb/gdb/darwin-nat.c:1709:8: error: must use 'class' tag to refer to type 'thread_info' in this scope
    for (thread_info *it : all_threads ())
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/thread_act.h:240:15: note:
    class 'thread_info' is hidden by a non-type declaration of 'thread_info' here
    kern_return_t thread_info

    Mach has a thread_info() function declared in that header, which darwin-nat.c #includes.

This patch fixes the problem by reintroducing the struct keyword.

2019-05-16  Tom Tromey  <tromey@adacore.com>

	* darwin-nat.c (thread_info_from_private_thread_info): Add struct
	keyword to foreach.
 gdb/ChangeLog    | 5 +++++
 gdb/darwin-nat.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
diff mbox


diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index e3368ce6471..8282ef27e61 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -1706,7 +1706,7 @@  darwin_attach_pid (struct inferior *inf)
 static struct thread_info *
 thread_info_from_private_thread_info (darwin_thread_info *pti)
-  for (thread_info *it : all_threads ())
+  for (struct thread_info *it : all_threads ())
       darwin_thread_info *iter_pti = get_darwin_thread_info (it);