[3/4] gdbserver: Ensure all debug output uses debug functions
Commit Message
All debug output needs to go via debug functions to ensure it writes to the
correct output stream.
gdb/ChangeLog:
2019-04-16 Alan Hayward <alan.hayward@arm.com>
* nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
gdb/gdbserver/ChangeLog:
2019-04-16 Alan Hayward <alan.hayward@arm.com>
* ax.c (ax_vdebug): Call debug_printf.
* debug.c (debug_write): New function.
* debug.h (debug_write): New declaration.
* linux-low.c (sigchld_handler): Call debug_write.
---
gdb/gdbserver/ax.c | 4 ++++
gdb/gdbserver/debug.c | 9 +++++++++
gdb/gdbserver/debug.h | 3 +++
gdb/gdbserver/linux-low.c | 7 +++----
gdb/nat/linux-waitpid.c | 2 +-
5 files changed, 20 insertions(+), 5 deletions(-)
--
2.20.1 (Apple Git-117)
Comments
>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
Alan> All debug output needs to go via debug functions to ensure it writes to the
Alan> correct output stream.
Alan> gdb/ChangeLog:
Alan> 2019-04-16 Alan Hayward <alan.hayward@arm.com>
Alan> * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
Alan> gdb/gdbserver/ChangeLog:
Alan> 2019-04-16 Alan Hayward <alan.hayward@arm.com>
Alan> * ax.c (ax_vdebug): Call debug_printf.
Alan> * debug.c (debug_write): New function.
Alan> * debug.h (debug_write): New declaration.
Alan> * linux-low.c (sigchld_handler): Call debug_write.
Thanks, this is ok.
Tom
@@ -36,7 +36,11 @@ ax_vdebug (const char *fmt, ...)
va_start (ap, fmt);
vsprintf (buf, fmt, ap);
+#ifdef IN_PROCESS_AGENT
fprintf (stderr, PROG "/ax: %s\n", buf);
+#else
+ debug_printf (PROG "/ax: %s\n", buf);
+#endif
va_end (ap);
}
@@ -131,3 +131,12 @@ do_debug_exit (const char *function_name)
if (function_name != NULL)
debug_printf ("<<<< exiting %s\n", function_name);
}
+
+/* See debug.h. */
+
+size_t
+debug_write (const void *buf, size_t nbyte)
+{
+ int fd = fileno (debug_file);
+ return write (fd, buf, nbyte);
+}
@@ -35,6 +35,9 @@ void debug_flush (void);
void do_debug_enter (const char *function_name);
void do_debug_exit (const char *function_name);
+/* Async signal safe debug output function that calls write directly. */
+size_t debug_write (const void *buf, size_t nbyte);
+
/* These macros are for use in major functions that produce a lot of
debugging output. They help identify in the mass of debugging output
when these functions enter and exit. debug_enter is intended to be
@@ -6185,10 +6185,9 @@ sigchld_handler (int signo)
{
do
{
- /* fprintf is not async-signal-safe, so call write
- directly. */
- if (write (2, "sigchld_handler\n",
- sizeof ("sigchld_handler\n") - 1) < 0)
+ /* Use the async signal safe debug function. */
+ if (debug_write ("sigchld_handler\n",
+ sizeof ("sigchld_handler\n") - 1) < 0)
break; /* just ignore */
} while (0);
}
@@ -42,7 +42,7 @@ linux_debug (const char *format, ...)
{
va_list args;
va_start (args, format);
- vfprintf (stderr, format, args);
+ debug_vprintf (format, args);
va_end (args);
}
#endif