From patchwork Tue Apr 9 18:09:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 32225 Received: (qmail 58978 invoked by alias); 9 Apr 2019 18:09:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 58951 invoked by uid 89); 9 Apr 2019 18:09:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=noticed X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Apr 2019 18:09:49 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id C444A472D86 for ; Tue, 9 Apr 2019 13:09:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DvBrhNUEb2qH7DvBrhkjIU; Tue, 09 Apr 2019 13:09:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7v9NKbbgonXKvZcyx/U4xNCmc/YSXaQaYjDw1QGgIdQ=; b=IfJGwBjjX6w8GCD9nuIwQhEbDK 7shfzX8jkkwMtgcnP9cYmPqJoe8xfS3dpZpnbPZToXvohVYC32SGTwnWDZ1ww8X8QCA96noq6ooN4 D/nYSDk7M3/XrNOgBZ6Kcsa45; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:33050 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hDvBr-003Khd-Hj; Tue, 09 Apr 2019 13:09:47 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/3] Fix a couple of comments Date: Tue, 9 Apr 2019 12:09:44 -0600 Message-Id: <20190409180945.21621-3-tom@tromey.com> In-Reply-To: <20190409180945.21621-1-tom@tromey.com> References: <20190409180945.21621-1-tom@tromey.com> While working on objfiles I noticed a typo in one comment, and another comment that, as far as I can tell, has been obsolete for a very long time. gdb/ChangeLog 2019-04-09 Tom Tromey * symfile.c (reread_symbols): Remove old comment. * objfiles.c (free_all_objfiles): Fix a typo. --- gdb/ChangeLog | 5 +++++ gdb/objfiles.c | 2 +- gdb/symfile.c | 6 ------ 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 1c95e068842..ada5edc42fa 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -699,7 +699,7 @@ free_all_objfiles (void) { struct so_list *so; - /* Any objfile referencewould become stale. */ + /* Any objfile reference would become stale. */ for (so = master_so_list (); so; so = so->next) gdb_assert (so->objfile == NULL); diff --git a/gdb/symfile.c b/gdb/symfile.c index ba82f1b83ca..dd9c4ae9856 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2432,12 +2432,6 @@ reread_symbols (void) int res; std::vector new_objfiles; - /* With the addition of shared libraries, this should be modified, - the load time should be saved in the partial symbol tables, since - different tables may come from different source files. FIXME. - This routine should then walk down each partial symbol table - and see if the symbol table that it originates from has been changed. */ - for (objfile *objfile : current_program_space->objfiles ()) { if (objfile->obfd == NULL)