From patchwork Tue Mar 26 14:43:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 31986 Received: (qmail 80370 invoked by alias); 26 Mar 2019 14:44:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 79396 invoked by uid 89); 26 Mar 2019 14:44:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=distinguished, HX-Languages-Length:1856, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Mar 2019 14:44:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C2324116C66; Tue, 26 Mar 2019 10:44:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YGwgwIF+SRvB; Tue, 26 Mar 2019 10:44:07 -0400 (EDT) Received: from murgatroyd.Home (174-29-37-56.hlrn.qwest.net [174.29.37.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 6DA20116C5F; Tue, 26 Mar 2019 10:44:07 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 3/8] Change names given to Ravenscar threads Date: Tue, 26 Mar 2019 08:43:59 -0600 Message-Id: <20190326144404.6670-4-tromey@adacore.com> In-Reply-To: <20190326144404.6670-1-tromey@adacore.com> References: <20190326144404.6670-1-tromey@adacore.com> MIME-Version: 1.0 Current a Ravenscar thread is given the same sort of name as a "CPU" thread; they can only be distinguished by looking at the output of "info thread". This patch changes ravenscar-thread.c to distinguish these threads, like: (gdb) continue Continuing. [New Ravenscar Thread 0x2b910] gdb/ChangeLog 2019-03-26 Tom Tromey * ravenscar-thread.c (ravenscar_thread_target) : Remove. (ravenscar_thread_target::extra_thread_info): Remove. (ravenscar_thread_target::pid_to_str): Mention Ravenscar in result; defer to target beneath for non-Ravenscar threads. --- gdb/ChangeLog | 8 ++++++++ gdb/ravenscar-thread.c | 13 ++++--------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/gdb/ravenscar-thread.c b/gdb/ravenscar-thread.c index a8f8ac8c440..a3545847288 100644 --- a/gdb/ravenscar-thread.c +++ b/gdb/ravenscar-thread.c @@ -108,8 +108,6 @@ struct ravenscar_thread_target final : public target_ops void update_thread_list () override; - const char *extra_thread_info (struct thread_info *) override; - std::string pid_to_str (ptid_t) override; ptid_t get_ada_task_ptid (long lwp, long thread) override; @@ -411,12 +409,6 @@ ravenscar_thread_target::active_task (int cpu) return ptid_t (m_base_ptid.pid (), 0, tid); } -const char * -ravenscar_thread_target::extra_thread_info (thread_info *tp) -{ - return "Ravenscar task"; -} - bool ravenscar_thread_target::thread_alive (ptid_t ptid) { @@ -427,7 +419,10 @@ ravenscar_thread_target::thread_alive (ptid_t ptid) std::string ravenscar_thread_target::pid_to_str (ptid_t ptid) { - return string_printf ("Thread %#x", (int) ptid.tid ()); + if (!is_ravenscar_task (ptid)) + return beneath ()->pid_to_str (ptid); + + return string_printf ("Ravenscar Thread %#x", (int) ptid.tid ()); } void