From patchwork Thu Mar 21 17:09:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 31936 Received: (qmail 79417 invoked by alias); 21 Mar 2019 17:09:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 78376 invoked by uid 89); 21 Mar 2019 17:09:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 17:09:09 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9ADD431688FA; Thu, 21 Mar 2019 17:09:08 +0000 (UTC) Received: from f29-4.lan (ovpn-117-184.phx2.redhat.com [10.3.117.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7092519C59; Thu, 21 Mar 2019 17:09:08 +0000 (UTC) Date: Thu, 21 Mar 2019 10:09:07 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Eli Zaretskii Subject: Re: [PATCH v3 6/6] Rename python function thread_from_thread_handle to thread_from_handle Message-ID: <20190321100907.2ffb49f5@f29-4.lan> In-Reply-To: <83d0mkux3f.fsf@gnu.org> References: <20190320213250.718c4c19@f29-4.lan> <20190320215155.0fbcee63@f29-4.lan> <83d0mkux3f.fsf@gnu.org> MIME-Version: 1.0 X-IsSubscribed: yes On Thu, 21 Mar 2019 16:21:40 +0200 Eli Zaretskii wrote: > > Date: Wed, 20 Mar 2019 21:51:55 -0700 > > From: Kevin Buettner > > Cc: Eli Zaretskii > > > > gdb/doc/ChangeLog: > > > > * python.texi (Inferiors In Python): Rename > > Inferior.thread_from_thread_handle to Inferior.thread_from_handle. > > Add note about the former being deprecated. > > This part is OK, with one comment: > > > -@findex Inferior.thread_from_thread_handle > > Please don't remove this index entry, it will be useful for someone > who sees code which uses the deprecated name and wants to know what > that is. I was wondering about that when I made the change. I've restored the index entry in my local sources. Here's what that part of it looks like now: diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index 2a5a5cde3d..ab191b620c 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -2906,11 +2906,16 @@ containing the address where the pattern was found, or @code{None} if the pattern could not be found. @end defun +@findex Inferior.thread_from_handle @findex Inferior.thread_from_thread_handle -@defun Inferior.thread_from_thread_handle (thread_handle) -Return the thread object corresponding to @var{thread_handle}, a thread +@defun Inferior.thread_from_handle (handle) +Return the thread object corresponding to @var{handle}, a thread library specific data structure such as @code{pthread_t} for pthreads library implementations. + +The function @code{Inferior.thread_from_thread_handle} provides +the same functionality, but use of @code{Inferior.thread_from_thread_handle} +is deprecated. @end defun @node Events In Python