[v3,2/6] Add python method InferiorThread.handle
Commit Message
gdb/ChangeLog:
* python/py-infthread.c (thpy_thread_handle): New function.
(thread_object_methods): Register thpy_thread_handle.
---
gdb/python/py-infthread.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
Comments
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> +static PyObject *
Kevin> +thpy_thread_handle (PyObject *self, PyObject *args)
[...]
Kevin> + if (hv.size () == 0)
Kevin> + return NULL;
A function like this must ensure that the Python exception is set before
returning NULL. I think more is needed here, because I don't think this
does that.
Tom
@@ -257,6 +257,34 @@ thpy_is_valid (PyObject *self, PyObject *args)
Py_RETURN_TRUE;
}
+/* Implementation of gdb.InferiorThread.handle (self) -> handle. */
+
+static PyObject *
+thpy_thread_handle (PyObject *self, PyObject *args)
+{
+ thread_object *thread_obj = (thread_object *) self;
+ THPY_REQUIRE_VALID (thread_obj);
+
+ gdb::byte_vector hv;
+
+ TRY
+ {
+ hv = target_thread_info_to_thread_handle (thread_obj->thread);
+ }
+ CATCH (ex, RETURN_MASK_ALL)
+ {
+ GDB_PY_HANDLE_EXCEPTION (ex);
+ }
+ END_CATCH
+
+ if (hv.size () == 0)
+ return NULL;
+
+ PyObject *object = PyBytes_FromStringAndSize ((const char *) hv.data (),
+ hv.size());
+ return object;
+}
+
/* Return a reference to a new Python object representing a ptid_t.
The object is a tuple containing (pid, lwp, tid). */
PyObject *
@@ -336,6 +364,9 @@ Return whether the thread is running." },
{ "is_exited", thpy_is_exited, METH_NOARGS,
"is_exited () -> Boolean\n\
Return whether the thread is exited." },
+ { "handle", thpy_thread_handle, METH_NOARGS,
+ "handle () -> handle\n\
+Return thread library specific handle for thread." },
{ NULL }
};