[2/2] Make null_ptid and minus_one_ptid "const"
Commit Message
This makes null_ptid and minus_one_ptid "const". I think this is an
improvement because it means they can't be accidentally modified.
xgdb/ChangeLog
2019-03-04 Tom Tromey <tromey@adacore.com>
* common/ptid.c (null_ptid, minus_one_ptid): Now const.
* common/ptid.h (null_ptid, minus_one_ptid): Now const.
---
gdb/ChangeLog | 5 +++++
gdb/common/ptid.c | 4 ++--
gdb/common/ptid.h | 4 ++--
3 files changed, 9 insertions(+), 4 deletions(-)
Comments
On Mon, 4 Mar 2019 13:25:16 -0700
Tom Tromey <tromey@adacore.com> wrote:
> This makes null_ptid and minus_one_ptid "const". I think this is an
> improvement because it means they can't be accidentally modified.
>
> xgdb/ChangeLog
> 2019-03-04 Tom Tromey <tromey@adacore.com>
>
> * common/ptid.c (null_ptid, minus_one_ptid): Now const.
> * common/ptid.h (null_ptid, minus_one_ptid): Now const.
LGTM.
Kevin
@@ -22,5 +22,5 @@
/* See ptid.h for these. */
-ptid_t null_ptid = ptid_t::make_null ();
-ptid_t minus_one_ptid = ptid_t::make_minus_one ();
+ptid_t const null_ptid = ptid_t::make_null ();
+ptid_t const minus_one_ptid = ptid_t::make_minus_one ();
@@ -145,11 +145,11 @@ private:
/* The null or zero ptid, often used to indicate no process. */
-extern ptid_t null_ptid;
+extern const ptid_t null_ptid;
/* The (-1,0,0) ptid, often used to indicate either an error condition
or a "don't care" condition, i.e, "run all threads." */
-extern ptid_t minus_one_ptid;
+extern const ptid_t minus_one_ptid;
#endif /* COMMON_PTID_H */