riscv-tdep.c in 32-bits build
Commit Message
* Simon Marchi <simon.marchi@ericsson.com> [2018-12-20 17:26:01 +0000]:
> Hi Andrew,
>
> I just noticed this error when building for i386-linux-gnu.
>
> CXX riscv-tdep.o
> /home/emaisin/src/binutils-gdb/gdb/riscv-tdep.c: In function ‘CORE_ADDR riscv_scan_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, riscv_unwind_cache*)’:
> /home/emaisin/src/binutils-gdb/gdb/riscv-tdep.c:1548:43: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘CORE_ADDR {aka long long unsigned int}’ [-Werror=format=]
> offset);
> ^
> I looked at it a bit and decided to let you choose how you wanted to fix
> it. Since this is a CORE_ADDR, I first thought we should call paddress.
> But this variable represents an offset, not an absolute address, so I am
> not sure if paddress is really appropriate.
Thanks for the report. The use of CORE_ADDR is not ideal, that's just
what the existing API into pv_area uses. Given it's an offset,
possibly LONGEST would be more appropriate?
Anyway, I propose casting to LONGEST and printing that. Unless you
object I'll push this in a few days.
Thanks,
Andrew
--
gdb/riscv: Format CORE_ADDR as a string for printing
Avoid compiler errors caused by trying to print CORE_ADDR using '%ld'
format, instead convert to a string and print that instead.
gdb/ChangeLog:
* riscv-tdep.c (riscv_scan_prologue): Use plongest to format
offset as a string.
---
gdb/ChangeLog | 5 +++++
gdb/riscv-tdep.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
Comments
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Anyway, I propose casting to LONGEST and printing that. Unless you
Andrew> object I'll push this in a few days.
It's fine; but as CORE_ADDR is (and will always be) unsigned, I think
you could use pulongest without a cast.
Tom
@@ -1543,9 +1543,9 @@ riscv_scan_prologue (struct gdbarch *gdbarch,
{
if (riscv_debug_unwinder)
fprintf_unfiltered (gdb_stdlog,
- "Register $%s at stack offset %ld\n",
+ "Register $%s at stack offset %s\n",
gdbarch_register_name (gdbarch, i),
- offset);
+ plongest ((LONGEST) offset));
trad_frame_set_addr (cache->regs, i, offset);
}
}