Message ID | 20181026221426.21608-1-jimw@sifive.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 114547 invoked by alias); 26 Oct 2018 22:14:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 114524 invoked by uid 89); 26 Oct 2018 22:14:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:6906, H*RU:209.85.210.194, Hx-spam-relays-external:209.85.210.194, HX-HELO:sk:mail-pf X-HELO: mail-pf1-f194.google.com Received: from mail-pf1-f194.google.com (HELO mail-pf1-f194.google.com) (209.85.210.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 22:14:31 +0000 Received: by mail-pf1-f194.google.com with SMTP id b11-v6so1190102pfi.5 for <gdb-patches@sourceware.org>; Fri, 26 Oct 2018 15:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id; bh=6rxn/Yw2qXozRcd6GskB0poyrWbhQd3LKneDsWKWdRA=; b=ktDoPctXdidOIbS1jGZEpiJNxFO8fnkLtFkgWdRhFKMCoavTaU8p6iHh3/lM0SBAHU E+jX+LJFBR3XuVJ0NSDeZ+JqyvzAlw9pwsvAcEERma6BbmDFVB4geFy2X5UX1Lkaacga yiW3+IxcjCIJW0WveHN8XmfqJmzGL2ZQv+shqlpri6nf74Nh0z9BHU1i7dXWqYtnXglu R56022/8sqjHxyPVcv8DyssU3zu5V08+xsUW5jRN7wYQzr07D+W0rKqD8ZFsLUIVVvpg uwNkFYb7oUClbDN+gMPkviWM9fS7ta4zeh5RdrLdugdaBOvwIPU4+BmrnHT+xcSNybp/ EkXw== Return-Path: <jimw@sifive.com> Received: from rohan.guest.sifive.com ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id t22-v6sm29370134pfk.141.2018.10.26.15.14.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 15:14:29 -0700 (PDT) From: Jim Wilson <jimw@sifive.com> To: gdb-patches@sourceware.org Cc: Jim Wilson <jimw@sifive.com> Subject: [PATCH] RISC-V: Force variables to .data for code_elim. Date: Fri, 26 Oct 2018 15:14:26 -0700 Message-Id: <20181026221426.21608-1-jimw@sifive.com> |
Commit Message
Jim Wilson
Oct. 26, 2018, 10:14 p.m. UTC
RISC-V puts a global variable in .sdata by default, which causes the add-symbol-file commands with -s .data to fail as there is no .data section. This fixes 3 testsuite failures. Jim gdb/testsuite/ * gdb.base/code_elim.exp: For riscv, set additional_flags to include -msmall-data-limit=0. --- gdb/testsuite/gdb.base/code_elim.exp | 5 +++++ 1 file changed, 5 insertions(+)
Comments
Hi Andrew, While scanning my inbox, I saw this was unanswered. This looks good to me, but you (or Palmer) should probably approve. Simon On 2018-10-26 6:14 p.m., Jim Wilson wrote: > RISC-V puts a global variable in .sdata by default, which causes the > add-symbol-file commands with -s .data to fail as there is no .data section. > This fixes 3 testsuite failures. > > Jim > > gdb/testsuite/ > * gdb.base/code_elim.exp: For riscv, set additional_flags > to include -msmall-data-limit=0. > --- > gdb/testsuite/gdb.base/code_elim.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/code_elim.exp b/gdb/testsuite/gdb.base/code_elim.exp > index 962df4d773..1c76827754 100644 > --- a/gdb/testsuite/gdb.base/code_elim.exp > +++ b/gdb/testsuite/gdb.base/code_elim.exp > @@ -28,6 +28,11 @@ lappend opts "additional_flags=-fdata-sections" > lappend opts "additional_flags=-Wl,-gc-sections" > lappend opts "additional_flags=-Wl,-e,main" > > +# Place variables in .data instead of .sdata. > +if {[istarget "riscv*-*-*"]} { > + lappend opts "additional_flags=-msmall-data-limit=0" > +} > + > remote_exec build "rm -f ${binfile1}" > remote_exec build "rm -f ${binfile2}" > >
* Jim Wilson <jimw@sifive.com> [2018-10-26 15:14:26 -0700]: > RISC-V puts a global variable in .sdata by default, which causes the > add-symbol-file commands with -s .data to fail as there is no .data section. > This fixes 3 testsuite failures. > > Jim > > gdb/testsuite/ > * gdb.base/code_elim.exp: For riscv, set additional_flags > to include -msmall-data-limit=0. This is fine with me. Sorry for not reviewing this earlier. Thanks, Andrew > --- > gdb/testsuite/gdb.base/code_elim.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/code_elim.exp b/gdb/testsuite/gdb.base/code_elim.exp > index 962df4d773..1c76827754 100644 > --- a/gdb/testsuite/gdb.base/code_elim.exp > +++ b/gdb/testsuite/gdb.base/code_elim.exp > @@ -28,6 +28,11 @@ lappend opts "additional_flags=-fdata-sections" > lappend opts "additional_flags=-Wl,-gc-sections" > lappend opts "additional_flags=-Wl,-e,main" > > +# Place variables in .data instead of .sdata. > +if {[istarget "riscv*-*-*"]} { > + lappend opts "additional_flags=-msmall-data-limit=0" > +} > + > remote_exec build "rm -f ${binfile1}" > remote_exec build "rm -f ${binfile2}" > > -- > 2.17.1 >
On Tue, Nov 6, 2018 at 1:49 AM Andrew Burgess <andrew.burgess@embecosm.com> wrote: > > gdb/testsuite/ > > * gdb.base/code_elim.exp: For riscv, set additional_flags > > to include -msmall-data-limit=0. > > This is fine with me. Sorry for not reviewing this earlier. > > Thanks, > Andrew Committed and pushed. Jim
diff --git a/gdb/testsuite/gdb.base/code_elim.exp b/gdb/testsuite/gdb.base/code_elim.exp index 962df4d773..1c76827754 100644 --- a/gdb/testsuite/gdb.base/code_elim.exp +++ b/gdb/testsuite/gdb.base/code_elim.exp @@ -28,6 +28,11 @@ lappend opts "additional_flags=-fdata-sections" lappend opts "additional_flags=-Wl,-gc-sections" lappend opts "additional_flags=-Wl,-e,main" +# Place variables in .data instead of .sdata. +if {[istarget "riscv*-*-*"]} { + lappend opts "additional_flags=-msmall-data-limit=0" +} + remote_exec build "rm -f ${binfile1}" remote_exec build "rm -f ${binfile2}"