From patchwork Fri Sep 28 20:35:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 29576 Received: (qmail 105285 invoked by alias); 28 Sep 2018 20:35:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105269 invoked by uid 89); 28 Sep 2018 20:35:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=wind, 1o X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Sep 2018 20:35:45 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 40DA9D55 for ; Fri, 28 Sep 2018 15:35:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5zTzgBwyd8YaU5zU8gfdiA; Fri, 28 Sep 2018 15:35:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K0tPzt/T9ZddeRsbHbMoHXMqJoJxRPvipgTsn5m53Jg=; b=u9gGitT9tLc8QYBLMAbCkXMHop en3kI7C3U/o7WyZ+mCI2hCqGPKcHa8yt5zl48p7eUK1skSFsKdTChSl8ZUjAGtiCwRAEf/6D3fvOc I+dxBibSzad1qoR5c+FQxqZUn; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:52558 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g5zTy-000LQe-Im; Fri, 28 Sep 2018 15:35:26 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use standard_output_file in a couple more places Date: Fri, 28 Sep 2018 14:35:16 -0600 Message-Id: <20180928203516.7897-1-tom@tromey.com> I noticed a few files left over in the testsuite/ directory in the build tree after running tests. Normally output files should not wind up there, but instead should end up in the test's subdirectory. This isn't always crucial, but in the past there were problems with tests clashing, preventing parallel runs, and so it is better to be clean here. This patch changes a couple of tests to use standard_output_file to fix this problem. Tested by re-running the tests in question and examining the directory. gdb/testsuite/ChangeLog 2018-09-28 Tom Tromey * gdb.base/gnu-ifunc.exp (build): Use standard_output_file. * gdb.trace/unavailable-dwarf-piece.exp: Use standard_output_file. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/gnu-ifunc.exp | 2 +- gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/gnu-ifunc.exp b/gdb/testsuite/gdb.base/gnu-ifunc.exp index d6ec6988a7..8f122a0097 100644 --- a/gdb/testsuite/gdb.base/gnu-ifunc.exp +++ b/gdb/testsuite/gdb.base/gnu-ifunc.exp @@ -72,7 +72,7 @@ proc build {resolver_attr resolver_debug final_debug} { lappend final_opts "debug" } - set final_o $final_file-$suffix.o + set final_o [standard_output_file $final_file-$suffix.o] if { [gdb_compile_shlib ${srcdir}/${subdir}/$libsrc \ $lib_so $lib_opts] != "" diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp index 9fd3a739a7..49bfba8a05 100644 --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp @@ -22,7 +22,7 @@ if {![dwarf2_support]} { standard_testfile .c -set asm_file "${testfile}-dbg.s" +set asm_file [standard_output_file "${testfile}-dbg.s"] set opts {} if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile}1.o \