From patchwork Tue Sep 11 08:56:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 29299 Received: (qmail 82082 invoked by alias); 11 Sep 2018 08:56:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 81894 invoked by uid 89); 11 Sep 2018 08:56:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=guaranty, felt X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 08:56:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8941C117967; Tue, 11 Sep 2018 04:56:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ng+956S4zaXP; Tue, 11 Sep 2018 04:56:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 58213117932; Tue, 11 Sep 2018 04:56:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5D7E283B28; Tue, 11 Sep 2018 10:56:12 +0200 (CEST) Date: Tue, 11 Sep 2018 10:56:12 +0200 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, Jerome Guitton Subject: Re: [RFA v2] arm-pikeos: software single step Message-ID: <20180911085612.GA3379@adacore.com> References: <20180910174345.GD3234@adacore.com> <1536604744-3814-1-git-send-email-y> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) > (not sure why the From address is y@eu.adacore.com, I'll replace it with > Joel's). It was my mistake answering "y" rather than just typing answer to use my email address as the default when "git send-email" asked me about it. Sorry, and thanks for fixing! > > + symbol_table = (asymbol **) xmalloc (storage_needed); > > + make_cleanup (xfree, symbol_table); > > It would make Tom really happy if you could avoid introducing a cleanup :). > I would suggest using an std::vector. If you'd rather not do it > it's not a big deal, we can change it after. Attached is the patch I am testing. I am wondering if this is the best way, though. What do you think? One question I asked myself is whether we needed the std::vector at all, as the building of the vector is a bit clunky in this situation. As I understand it, this is mostly to automate the destruction of the array. I was wondering whether we could do without the std::vector entirely, and just handle the array without a cleanup, since the code is simple enough that we can make sure it doesn't throw (I was hoping that eg marking the function noexcept would help guaranty that). But at the end of the day, although it's manageable in this case, I felt it was better to go with the safer approach. Same remark with resizing the array: In practice, we don't need to do it since we know the bounds and iterate over the elements without accessing the them from the vector; but it's clearer and safer this way. > > diff --git a/gdb/configure.tgt b/gdb/configure.tgt > > index 6d1a4df..a1f703f 100644 > > --- a/gdb/configure.tgt > > +++ b/gdb/configure.tgt > > @@ -180,6 +180,7 @@ arm*-*-symbianelf*) > > ;; > > arm*-*-*) > > # Target: ARM embedded system > > + gdb_target_obs="arm-pikeos-tdep.o" > > gdb_sim=../sim/arm/libsim.a > > ;; > > The object should be added to ALL_TARGETS_OBS in the Makefile, so it's > included in an enable-targets=all build. Argh, yes, true. Added. > Just to understand better why the object file needs to be added here, what > is the target triplet? arm-pikeos-something, arm-none-something? It is arm-*-pikeos*, which config.sub then translates to arm-*-eabi. > Just wondering: when you connect to the target, you talk to a gdb stub > that is built right into the application/rtos? Something like that. We have to use a tool provided by the vendor called muxa; the tool connects to the system running PikeOS, and we connect to that tool using the remote protocol. Thanks for the review! From 5e98b8cb6fefc1419e3357675e3c5c6d375cc461 Mon Sep 17 00:00:00 2001 From: Jerome Guitton Date: Mon, 10 Sep 2018 13:04:41 +0200 Subject: [PATCH] arm-pikeos: software single step On ARM, PikeOS does not support hardware single step, causing various semi-random errors when trying to next/step over some user code. So this patch changes this target to use software-single-step instead. The challenge is that, up to now, the PikeOS target was in all respects identical to a baremetal target as far as GDB was concerned, meaning we were using the baremetal osabi for this target too. This is no longer possible, and we need to introduce a new OSABI variant. Unfortunately, there isn't anything in the object file that would allow us to differentiate between the two platforms. So we have to rely on a heuristic instead, where we look for some known symbols that are required in a PikeOS application (these symbols are expected to be defined by the default linker script, and correspond to routines used to allocate the application stack). gdb/ChangeLog: * defs.h (enum gdb_osabi): Add GDB_OSABI_PIKEOS. * osabi.c (gdb_osabi_names): Add name for GDB_OSABI_PIKEOS. * arm-pikeos-tdep.c: New file. * configure.tgt: Add arm-pikeos-tdep.o to the case of ARM embedded system. * Makefile.in (ALL_TARGET_OBS): Add arm-pikeos-tdep.o. Tested on arm-pikeos and arm-elf using AdaCore's testsuite. We also evaluated it on armhf-linux as a cross platform. --- gdb/Makefile.in | 1 + gdb/arm-pikeos-tdep.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++++ gdb/configure.tgt | 1 + gdb/defs.h | 1 + gdb/osabi.c | 1 + 5 files changed, 97 insertions(+) create mode 100644 gdb/arm-pikeos-tdep.c diff --git a/gdb/Makefile.in b/gdb/Makefile.in index d49f3ee..5d6e217 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -670,6 +670,7 @@ ALL_TARGET_OBS = \ arm-linux-tdep.o \ arm-nbsd-tdep.o \ arm-obsd-tdep.o \ + arm-pikeos-tdep.o \ arm-symbian-tdep.o \ arm-tdep.o \ arm-wince-tdep.o \ diff --git a/gdb/arm-pikeos-tdep.c b/gdb/arm-pikeos-tdep.c new file mode 100644 index 0000000..786f67a --- /dev/null +++ b/gdb/arm-pikeos-tdep.c @@ -0,0 +1,93 @@ +/* Copyright (C) 2016-2018 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include "defs.h" +#include "objfiles.h" +#include "arm-tdep.h" +#include "osabi.h" + +/* The gdbarch_register_osabi handler for ARM PikeOS; it performs + the gdbarch initialization for that platform. */ + +static void +arm_pikeos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) +{ + /* Single stepping. */ + set_gdbarch_software_single_step (gdbarch, arm_software_single_step); +} + +/* The ARM PikeOS OSABI sniffer (see gdbarch_register_osabi_sniffer). + Returns GDB_OSABI_PIKEOS if the given BFD is a PikeOS binary, + GDB_OSABI_UNKNOWN otherwise. */ + +static enum gdb_osabi +arm_pikeos_osabi_sniffer (bfd *abfd) +{ + long number_of_symbols; + long i; + int pikeos_stack_found = 0; + int pikeos_stack_size_found = 0; + + /* The BFD target of PikeOS is really just standard elf, so we + cannot use it to detect this variant. The only common thing that + may be found in PikeOS modules are symbols _vm_stack/__p4_stack and + _vm_stack_size/__p4_stack_end. They are used to specify the stack + location and size; and defined by the default linker script. + + OS ABI sniffers are called before the minimal symtabs are + created. So inspect the symbol table using BFD. */ + + long max_number_of_symbols + = bfd_get_symtab_upper_bound (abfd) / sizeof (asymbol *); + if (max_number_of_symbols <= 0) + return GDB_OSABI_UNKNOWN; + + std::vector symbol_table (max_number_of_symbols); + number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table.data ()); + if (number_of_symbols <= 0) + return GDB_OSABI_UNKNOWN; + gdb_assert (number_of_symbols <= max_number_of_symbols); + symbol_table.resize (number_of_symbols); + + for (i = 0; i < number_of_symbols; i++) + { + const char *name = bfd_asymbol_name (symbol_table[i]); + + if (strcmp (name, "_vm_stack") == 0 + || strcmp (name, "__p4_stack") == 0) + pikeos_stack_found = 1; + + if (strcmp (name, "_vm_stack_size") == 0 + || strcmp (name, "__p4_stack_end") == 0) + pikeos_stack_size_found = 1; + } + + if (pikeos_stack_found && pikeos_stack_size_found) + return GDB_OSABI_PIKEOS; + else + return GDB_OSABI_UNKNOWN; +} + +void +_initialize_arm_pikeos_tdep (void) +{ + /* Register the sniffer for the PikeOS targets. */ + gdbarch_register_osabi_sniffer (bfd_arch_arm, bfd_target_elf_flavour, + arm_pikeos_osabi_sniffer); + gdbarch_register_osabi (bfd_arch_arm, 0, GDB_OSABI_PIKEOS, + arm_pikeos_init_abi); +} diff --git a/gdb/configure.tgt b/gdb/configure.tgt index 6d1a4df..03c0268 100644 --- a/gdb/configure.tgt +++ b/gdb/configure.tgt @@ -180,6 +180,7 @@ arm*-*-symbianelf*) ;; arm*-*-*) # Target: ARM embedded system + gdb_target_obs="arm-pikeos-tdep.o" gdb_sim=../sim/arm/libsim.a ;; diff --git a/gdb/defs.h b/gdb/defs.h index fc42170..28f7a11 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -495,6 +495,7 @@ enum gdb_osabi GDB_OSABI_LYNXOS178, GDB_OSABI_NEWLIB, GDB_OSABI_SDE, + GDB_OSABI_PIKEOS, GDB_OSABI_INVALID /* keep this last */ }; diff --git a/gdb/osabi.c b/gdb/osabi.c index 7d0540b..68f4665 100644 --- a/gdb/osabi.c +++ b/gdb/osabi.c @@ -80,6 +80,7 @@ static const struct osabi_names gdb_osabi_names[] = { "LynxOS178", NULL }, { "Newlib", NULL }, { "SDE", NULL }, + { "PikeOS", NULL }, { "", NULL } }; -- 1.7.10.4