From patchwork Wed Aug 8 23:20:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28800 Received: (qmail 39937 invoked by alias); 8 Aug 2018 23:20:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 39897 invoked by uid 89); 8 Aug 2018 23:20:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1659 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 23:20:25 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 70A243DFE9 for ; Wed, 8 Aug 2018 18:20:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nXkZf3WG7aSeynXkcfbQ8t; Wed, 08 Aug 2018 18:20:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4WdjeV7K98x3pj/Dvumh+g/afJnZZuYB5dwy7btAEzI=; b=hUlKv8vq2L7JBAX293VCNJqKzw cRUVvXAAAuZpvH0Rkq1izhNjq0/nB7C/vfUXkOGv7aGflAdVcm2KOqItUlomlhtUf0su0JdMSklkd HcAcVEsRBdwtQJ6CjELJmaaRr; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:57736 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnXkZ-0023IS-4q; Wed, 08 Aug 2018 18:20:19 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/7] Change completion_tracker to use char type Date: Wed, 8 Aug 2018 17:20:10 -0600 Message-Id: <20180808232016.12777-2-tom@tromey.com> In-Reply-To: <20180808232016.12777-1-tom@tromey.com> References: <20180808232016.12777-1-tom@tromey.com> This changes completion_tracker to use the char type for the quote char. This avoids some narrowing warnings at the places where quote_char() is called. gdb/ChangeLog 2018-08-08 Tom Tromey * completer.h (completion_tracker::set_quote_char): Change parameter type to "char". (completion_tracker::quote_char): Return "char". Now const. (completion_tracker::m_quote_char): Now "char". --- gdb/ChangeLog | 7 +++++++ gdb/completer.h | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/gdb/completer.h b/gdb/completer.h index 2bdfa26f6c..9f10bf0ea8 100644 --- a/gdb/completer.h +++ b/gdb/completer.h @@ -329,13 +329,13 @@ public: /* Set the quote char to be appended after a unique completion is added to the input line. Set to '\0' to clear. See m_quote_char's description. */ - void set_quote_char (int quote_char) + void set_quote_char (char quote_char) { m_quote_char = quote_char; } /* The quote char to be appended after a unique completion is added to the input line. Returns '\0' if no quote char has been set. See m_quote_char's description. */ - int quote_char () { return m_quote_char; } + char quote_char () const { return m_quote_char; } /* Tell the tracker that the current completer wants to provide a custom word point instead of a list of a break chars, in the @@ -450,7 +450,7 @@ private: before tab: "b 'function(" after tab: "b 'function()' " */ - int m_quote_char = '\0'; + char m_quote_char = '\0'; /* If true, the completer has its own idea of "word" point, and doesn't want to rely on readline computing it based on brkchars.