From patchwork Thu May 24 21:27:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Waroquiers X-Patchwork-Id: 27493 Received: (qmail 120264 invoked by alias); 24 May 2018 21:28:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119718 invoked by uid 89); 24 May 2018 21:28:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 May 2018 21:28:04 +0000 IronPort-PHdr: =?us-ascii?q?9a23=3ApOWsrxZQ1Yt8hmwDdT/yCXP/LSx+4OfEezUN459i?= =?us-ascii?q?sYplN5qZr8+8bnLW6fgltlLVR4KTs6sC17KN9fi4EUU7or+5+EgYd5JNUxJXwe?= =?us-ascii?q?43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRp?= =?us-ascii?q?OOv1BpTSj8Oq3Oyu5pHfeQpFiCazbL9oMBm6sRjau9ULj4dlNqs/0AbCrGFSe+?= =?us-ascii?q?RRy2NoJFaTkAj568yt4pNt8Dletuw4+cJYXqr0Y6o3TbpDDDQ7KG81/9HktQPC?= =?us-ascii?q?TQSU+HQRVHgdnwdSDAjE6BH6WYrxsjf/u+Fg1iSWIdH6QLYpUjmk8qxlSgLniD?= =?us-ascii?q?0fOjA57m/Zl8J+gqFcrh+6uxBz35TZbJ2POfZiYq/Qe84RS2pbXsZWUixMGpmy?= =?us-ascii?q?b4sOD+oFPOZYt5H9qEUTphS+HwasHuTvyiZVhn/3w6I6yf8hGhzB0Qw4H9IOsX?= =?us-ascii?q?DUrNTtNKcKT++51qfJwi/Zb/NRwDf99YnIfQ47ofGXRr9wasnRyEkpFwzbklWc?= =?us-ascii?q?s5fqMC2M2+kLrmOV7PJgWPqshmI6sQ19vDeiyto2hoTJm44Z0E3I+Tl6zYszON?= =?us-ascii?q?a2UlR0YcS+H5tVryyaMox2Td48TGxwoyY6z6EGuYa8fCgX1JQr3x7fZOKDc4iP?= =?us-ascii?q?+h/jUfueLS14hHJifbKwmQ6+8UmmyuLiSsm5yFVHojdfntXSuX0Bygbf58iaRv?= =?us-ascii?q?dn40utxTWC2xjW6u5eIEA0kaTbK4Qmwr41jpcTqUTDHi7ymEX3lK+Wblsr9vKm?= =?us-ascii?q?6uv9eLXmoYacN5J1ig7gKKQugdeyAf87MgkOWWiU5/i82Kf48kLnWLlKlOE5kr?= =?us-ascii?q?HFsJDGIsQWvqG5DBJO3Yo68xawFSum38gYnXYZN1JIYwmHj4/0O1HUPP/3E/m+?= =?us-ascii?q?jE62kDh13fzGOafhAprVJHjZjLjhZap961JbyAcr1dBf55NUCrUAIPLrQk/+qs?= =?us-ascii?q?bUDxEjPAyuxObnEch91oIAVmKVGa+UK7jSsVyI5+IpPeaMeJUZty3jJKtt2/m7?= =?us-ascii?q?gnMz3EcUYaKp0IA/c3elBP9rPEyDbDzrmNhSP30Nu18GTO3uiUWaXHZsbmy1Rr?= =?us-ascii?q?896ysgQNa+DYbHR5i1jfqe1T28B4BXa3pdIkuPAHHla8OOVqFfO2qpPsZ9n2lc?= =?us-ascii?q?BvCaQIg72ET2uQ=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DzBwCWLQdb/2wz8VFbg3UkPn0ojFqMB?= =?us-ascii?q?wGCKQFdlTELGxABhECCDCI4FAECAQEBAQEBAgFrKII1IoMuI09LN4MiAoIDrii?= =?us-ascii?q?EWINpgXyKCj+DZweFbYUIAphfBwKBZ4QDiGULjQQBK5BWgVghgVJtgxYJghcXj?= =?us-ascii?q?hk9MHgBGgGNHwEB?= X-IPAS-Result: =?us-ascii?q?A2DzBwCWLQdb/2wz8VFbg3UkPn0ojFqMBwGCKQFdlTELGxA?= =?us-ascii?q?BhECCDCI4FAECAQEBAQEBAgFrKII1IoMuI09LN4MiAoIDriiEWINpgXyKCj+DZ?= =?us-ascii?q?weFbYUIAphfBwKBZ4QDiGULjQQBK5BWgVghgVJtgxYJghcXjhk9MHgBGgGNHwE?= =?us-ascii?q?B?= Received: from 108.51-241-81.adsl-dyn.isp.belgacom.be (HELO md.home) ([81.241.51.108]) by relay.skynet.be with ESMTP/TLS/DHE-RSA-AES128-GCM-SHA256; 24 May 2018 23:28:02 +0200 From: Philippe Waroquiers To: gdb-patches@sourceware.org Cc: Philippe Waroquiers Subject: [PATCH] (obvious): Fix a comment, and pass stream to cb_data. Date: Thu, 24 May 2018 23:27:55 +0200 Message-Id: <20180524212755.7995-1-philippe.waroquiers@skynet.be> X-IsSubscribed: yes iterate_over_block_arg_vars is a void function, so does not return 1 or 0. print_frame_arg_vars tells it prints on STREAM, so pass STREAM in the cb_data, not gdb_stdout. gdb/ChangeLog 2018-05-24 Philippe Waroquiers * stack.c (iterate_over_block_arg_vars): Fix comment. (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout. --- gdb/ChangeLog | 5 +++++ gdb/stack.c | 6 ++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 503b34f26a..6a1aae8523 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-24 Philippe Waroquiers + + * stack.c (iterate_over_block_arg_vars): Fix comment. + (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout. + 2018-05-24 Andrew Burgess PR gdb/23203 diff --git a/gdb/stack.c b/gdb/stack.c index 98a21842e7..016ee1d58b 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -2059,9 +2059,7 @@ info_locals_command (const char *args, int from_tty) 0, gdb_stdout); } -/* Iterate over all the argument variables in block B. - - Returns 1 if any argument was walked; 0 otherwise. */ +/* Iterate over all the argument variables in block B. */ void iterate_over_block_arg_vars (const struct block *b, @@ -2121,7 +2119,7 @@ print_frame_arg_vars (struct frame_info *frame, struct ui_file *stream) cb_data.frame_id = get_frame_id (frame); cb_data.num_tabs = 0; - cb_data.stream = gdb_stdout; + cb_data.stream = stream; cb_data.values_printed = 0; iterate_over_block_arg_vars (SYMBOL_BLOCK_VALUE (func),