From patchwork Tue Jan 30 04:09:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 25684 Received: (qmail 19163 invoked by alias); 30 Jan 2018 04:09:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19153 invoked by uid 89); 30 Jan 2018 04:09:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=won X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jan 2018 04:09:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DD446560A5; Mon, 29 Jan 2018 23:09:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zuGWH-sy6AM9; Mon, 29 Jan 2018 23:09:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6AAE15601D; Mon, 29 Jan 2018 23:09:53 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3855783307; Tue, 30 Jan 2018 08:09:49 +0400 (+04) Date: Tue, 30 Jan 2018 08:09:49 +0400 From: Joel Brobecker To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org, Keith Seitz , Xavier Roirand Subject: Re: [RFA/linespec] wrong line number in breakpoint location Message-ID: <20180130040949.mbvm33n7atqvuik3@adacore.com> References: <1513565091-118926-1-git-send-email-brobecker@adacore.com> <20171219092405.n2dql5ji52qhjilj@adacore.com> <206d75d6b1f14e55b6a0dff523d8c722@polymtl.ca> <20171221113127.ijqv6dnzjfifwfnb@adacore.com> <20171221113214.hezwvaatnbd4yzfq@adacore.com> <5bc2ff63-7341-4000-8ec4-d56c87779c3d@ericsson.com> <20180129044505.mtvh2ps464imwp2t@adacore.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) > Thanks, this is fine with me. Just a really small nit, I would suggest > initializing the line_actual variable to 0 or -1 (an invalid line number) > prior to calling gdb_test_multiple. This way, if that test fails, > line_actual will still be defined, and the expression that refers to it will > generate a FAIL instead of an unreadable tcl backtrace. Sounds good. Just for kicks, I took at look at what it looks like when the variable is undefined, and the error message is obvious about why it fails. When the error is defined, however, you have to figure out what the difference is, and track the value of that variable down. What won me over to your suggestion is that the error can go unnoticed if you just compare .sum files... Attached is the patch I just pushed (re-tested on x86_64-linux). From fc413dc467e4c46013f6e5a60dc5db24d63f72ea Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 29 Jan 2018 23:03:09 -0500 Subject: [PATCH] gdb.base/break.exp: fix last "info break" test failure on Ubuntu 16.04 The last test of this testcase fails when run on Ubuntu 16.04 using the system compiler (16.04): FAIL: gdb.base/break.exp: verify that they were cleared This is because the testcase expected that a breakpoint on line 47 of break.c... printf ("%d\n", factorial (atoi ("6"))); /* set breakpoint 1 here */ ... would actually be inserted on an instruction belonging to that line. However, what actually happens is that system GCC on that version of Ubuntu ends up inlining everything, including the call to printf, thus reporting every instruction of generated for this line of code as belonging to a different function. As a result, GDB ends up insering the breakpoint on the next line of code, which is line 49: (gdb) break break.c:$l Breakpoint 3 at 0x4005c1: file /[...]/gdb.base/break.c, line 49. This causes a spurious failure in the "info break" test later on, as it assumed that the breakpoint above is inserted on line 47: gdb_test "info break" "$srcfile:$line" "verify that they were cleared" This patch fixes the issue by saving the actual source location where the breakpoint was inserted. gdb/testsuite/ChangeLog: * gdb.base/break.exp: Save the location where the breakpoint on break.c:47 was actually inserted when debugging the version compiled at -O2 and use it in the expected output of the "info break" test performed soon after. tested on x86_64-linux, with two configurations: - Ubuntu 16.04 with the system compiler (breakpoint lands on line 49) - Ubuntu 16.04 with GCC 7.3.1 (breakpoint lands on line 47) --- gdb/testsuite/ChangeLog | 7 +++++++ gdb/testsuite/gdb.base/break.exp | 17 +++++++++++++++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0f02f4a..52a689f 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2018-01-30 Joel Brobecker + + * gdb.base/break.exp: Save the location where the breakpoint + on break.c:47 was actually inserted when debugging the version + compiled at -O2 and use it in the expected output of the "info + break" test performed soon after. + 2018-01-22 Pedro Alves Sergio Durigan Junior diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index 8a21222..7f035a8 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -847,7 +847,20 @@ gdb_test_multiple "" $test { # set line [gdb_get_line_number "set breakpoint 1 here"] gdb_test_no_output "set \$l = $line" -gdb_breakpoint ${srcfile}:\$l + +set line_actual "-1" +set test "break ${srcfile}:\$l" +gdb_test_multiple "$test" $test { + -re "Breakpoint $decimal at $hex: file .*break\\.c, line ($decimal)\\.\r\n$gdb_prompt $" { + # Save the actual line number on which the breakpoint was + # actually set. On some systems (Eg: Ubuntu 16.04 with GCC + # version 5.4.0), that line gets completely inlined, including + # the call to printf, and so we end up inserting the breakpoint + # on one of the following lines instead. + set line_actual $expect_out(1,string) + pass $test + } +} gdb_test_no_output "set \$foo=81.5" \ "set convenience variable \$foo to 81.5" @@ -865,4 +878,4 @@ gdb_test "commands\nend" ">end" "clear breakpoint commands" # We verify that the commands were cleared by ensuring that the last # breakpoint's location ends the output -- if there were commands, # they would have been printed after the location. -gdb_test "info break" "$srcfile:$line" "verify that they were cleared" +gdb_test "info break" "$srcfile:$line_actual" "verify that they were cleared" -- 2.1.4