From patchwork Sun Jan 21 00:01:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 25474 Received: (qmail 48900 invoked by alias); 21 Jan 2018 00:01:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48884 invoked by uid 89); 21 Jan 2018 00:01:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f180.google.com Received: from mail-wr0-f180.google.com (HELO mail-wr0-f180.google.com) (209.85.128.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 21 Jan 2018 00:01:56 +0000 Received: by mail-wr0-f180.google.com with SMTP id z48so4832952wrz.6 for ; Sat, 20 Jan 2018 16:01:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EsWKCpBTEGOl2Uyiz1tDv1UYZWWt9CnbRF3PLjWTRL4=; b=TZSkpkJc1Ok3orfUKlq+AAVpPAB021eBnT8B33zpTskxL7aF+4fK4s6Zsra+0xvBvd ovceKzM3V1gsTmfDwreiiUyz1yxZ6oSmGHoHnecAs3HlfTXf956BvEv9HEzqiGr5eyLh bLyLVc8Pkg9KIHEZUovwENdiPDBv47NMxBN+FdbGGY+/UZgVbECocrbeJjIK3i9/Wbeb cdg7sSRwNLGRC0IcxSbeGMsMF2t1OCavrY0XXLCmuIS70U6DmP5/EErr4RiUUkbmK6Hi nBrQmJNpijssOJueGvO4qSGqrLOB+WbGFOu36bXr7tstBmuWMr8yYhL/qjIr+bMJ3qGJ SPXw== X-Gm-Message-State: AKwxytfqoJ0hH97SuwhyomHaBHKBqxP+mxY7mF14z+JvzNtVObLxKeXI Qdyp47QBy6A0pjDb3QKjV60SieMO X-Google-Smtp-Source: AH8x225feLW5/AwVFbT7qOgFUjx+ys3wg/LL0GqkyoHXvtBPPBwC6wQxq3PjvZAWwm6pAAYvQbnEXg== X-Received: by 10.223.157.196 with SMTP id q4mr2241786wre.55.1516492914144; Sat, 20 Jan 2018 16:01:54 -0800 (PST) Received: from localhost (host86-164-103-151.range86-164.btcentralplus.com. [86.164.103.151]) by smtp.gmail.com with ESMTPSA id y23sm16222631wrc.24.2018.01.20.16.01.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Jan 2018 16:01:53 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb: Add test for some error cases of @entry usage Date: Sun, 21 Jan 2018 00:01:51 +0000 Message-Id: <20180121000151.29174-1-andrew.burgess@embecosm.com> X-IsSubscribed: yes Adds a test that using @entry for a non-parameter, or for an unknown symbol, both give the expected error. This error message was previously untested. gdb/testsuite/ChangeLog: * gdb.arch/amd64-entry-value.exp: Test using @entry on a non-parameter, and on an unknown symbol. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.arch/amd64-entry-value.exp | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value.exp b/gdb/testsuite/gdb.arch/amd64-entry-value.exp index 46a896fdec0..72700d55c23 100644 --- a/gdb/testsuite/gdb.arch/amd64-entry-value.exp +++ b/gdb/testsuite/gdb.arch/amd64-entry-value.exp @@ -87,6 +87,14 @@ gdb_test "p d9@entry" " = 11\\.5" "entry_stack: p d9@entry" gdb_test "p da" " = 4\\.5" "entry_stack: p da" gdb_test "p da@entry" " = 12\\.5" "entry_stack: p da@entry" +# Test @entry values for a static file scoped variable, and for an +# unknown symbol. Both of these should give an error. +gdb_test "p v@entry" \ + "@entry can be used only for function parameters, not for \"v\"" \ + "attempt to print global v@entry" +gdb_test "p unknown@entry" \ + "@entry can be used only for function parameters, not for \"unknown\"" \ + "attempt to print unknown@entry" # Test various kinds of `set print entry-values'.