From patchwork Tue Dec 19 14:22:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 25009 Received: (qmail 23233 invoked by alias); 19 Dec 2017 14:23:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23190 invoked by uid 89); 19 Dec 2017 14:23:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:4940, dots X-HELO: mail-pl0-f43.google.com Received: from mail-pl0-f43.google.com (HELO mail-pl0-f43.google.com) (209.85.160.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Dec 2017 14:23:10 +0000 Received: by mail-pl0-f43.google.com with SMTP id o2so7031070plk.12 for ; Tue, 19 Dec 2017 06:23:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ob0Z/BxFrhHlx4j1xM77XiM7nBIA2UJUdpKqKGfqXEE=; b=RUkBDyPqJaB11RN529BXfc5JX9bIqQUT3IfS67kRf9xmcj5doO4kbxV1koYOyZk3Nu 6ngDfkgTvefTOzI0lytVfHuA65aGE1twKkcSVE73b5w9nrdwztAUxStZjcF9AiPl1QXz uAxXJnCQpcrB56MoiDl0CfWk9OSuUDIsbPuUfPNJMa7h+5ZBWlF/gW4YKzDmHnz/pWnq T7Ou9Gky4znGOytTo3RBX9cPmyldCZLWLjT3qnQluTzm0q4rDU41Gue1m64BxWslKdd/ wfK9Z2St5LR50MXe4DFjl/uKbU5XQxdHSnRJMrEDn//fuarkbK0KcbtvvkLesW99Gjpy ZhdA== X-Gm-Message-State: AKGB3mIL2j12GCEOZ29MnZn9DJkrCLZnnX2Nzg6YCF+gmOJ2ehb50WJt xEw5kzpOOldnlHHZaoGVTMIQVP9m X-Google-Smtp-Source: ACJfBov9kPKdKZQTqTq3my9dCeQ20sAh1ahAgzxD8z5yuKGrZTjrb5NrQG0fyCscB4Qw9JlvvJ70vg== X-Received: by 10.84.248.148 with SMTP id q20mr3541080pll.110.1513693388390; Tue, 19 Dec 2017 06:23:08 -0800 (PST) Received: from localhost (g41.219-103-184.ppp.wakwak.ne.jp. [219.103.184.41]) by smtp.gmail.com with ESMTPSA id r62sm31252023pfi.184.2017.12.19.06.23.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 06:23:07 -0800 (PST) From: Stafford Horne To: GDB patches Cc: Openrisc , Stafford Horne Subject: [PATCH v3 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Date: Tue, 19 Dec 2017 23:22:54 +0900 Message-Id: <20171219142257.13402-2-shorne@gmail.com> In-Reply-To: <20171219142257.13402-1-shorne@gmail.com> References: <20171219142257.13402-1-shorne@gmail.com> X-IsSubscribed: yes Until now this feature has existed but was not documented. Adding docs and tests. gdb/ChangeLog: 2017-06-06 Stafford Horne * infcmd.c (_initialize_infcmd): Add help for info reg $reggroup feature. gdb/doc/ChangeLog: 2017-06-06 Stafford Horne * gdb.texinfo (Registers): Document info reg $reggroup feature. gdb/testsuite/ChangeLog: 2017-06-06 Stafford Horne * gdb.base/reggroups.c: New file. * gdb.base/reggroups.exp: New file. --- gdb/doc/gdb.texinfo | 5 +++ gdb/infcmd.c | 8 +++-- gdb/testsuite/gdb.base/reggroups.c | 5 +++ gdb/testsuite/gdb.base/reggroups.exp | 63 ++++++++++++++++++++++++++++++++++++ 4 files changed, 79 insertions(+), 2 deletions(-) create mode 100644 gdb/testsuite/gdb.base/reggroups.c create mode 100644 gdb/testsuite/gdb.base/reggroups.exp diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 60ed80c363..e169260e7e 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -11023,6 +11023,11 @@ and vector registers (in the selected stack frame). Print the names and values of all registers, including floating-point and vector registers (in the selected stack frame). +@item info registers @var{reggroup} @dots{} +Print the name and value of the registers in each of the specified +@var{reggroup}. The @var{reggoup} can be any of those returned by +@code{maint print reggroups}. + @item info registers @var{regname} @dots{} Print the @dfn{relativized} value of each specified register @var{regname}. As discussed in detail below, register values are normally relative to diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 8bde28eab6..6e449d4a0e 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -3460,13 +3460,17 @@ interrupt all running threads in non-stop mode, use the -a option.")); c = add_info ("registers", info_registers_command, _("\ List of integer registers and their contents, for selected stack frame.\n\ -Register name as argument means describe only that register.")); +Register name as argument means describe only that register.\n\ +Register group name as argument means describe the registers in the\n\ +named register group.")); add_info_alias ("r", "registers", 1); set_cmd_completer (c, reg_or_group_completer); c = add_info ("all-registers", info_all_registers_command, _("\ List of all registers and their contents, for selected stack frame.\n\ -Register name as argument means describe only that register.")); +Register name as argument means describe only that register.\n\ +Register group name as argument means describe the registers in the\n\ +named register group.")); set_cmd_completer (c, reg_or_group_completer); add_info ("program", info_program_command, diff --git a/gdb/testsuite/gdb.base/reggroups.c b/gdb/testsuite/gdb.base/reggroups.c new file mode 100644 index 0000000000..8e8f518aae --- /dev/null +++ b/gdb/testsuite/gdb.base/reggroups.c @@ -0,0 +1,5 @@ +int +main() +{ + return 0; +} diff --git a/gdb/testsuite/gdb.base/reggroups.exp b/gdb/testsuite/gdb.base/reggroups.exp new file mode 100644 index 0000000000..c10f02567d --- /dev/null +++ b/gdb/testsuite/gdb.base/reggroups.exp @@ -0,0 +1,63 @@ +# This testcase is part of GDB, the GNU debugger. + +# Copyright 2017 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test listing reggroups and the registers in each group. + +standard_testfile + +if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { + return -1 +} + +if ![runto_main] then { + fail "can't run to main" + return 0 +} + +proc fetch_reggroups {test} { + global gdb_prompt + global expect_out + + set reggroups {} + gdb_test_multiple "maint print reggroups" "get reggroups" { + -re "maint print reggroups\r\n" { + exp_continue + } + -re "^ Group\[ \t\]+Type\[ \t\]+\r\n" { + exp_continue + } + -re "^ (\[0-9a-zA-Z\-\]+)\[ \t\]+(user|internal)\[ \t\]+\r\n" { + lappend reggroups $expect_out(1,string) + exp_continue + } + -re ".*$gdb_prompt $" { + if { [llength $reggroups] != 0 } { + pass $test + } else { + fail "$test - didn't fetch any reggroups" + } + } + } + + return $reggroups +} + +set reggroups [fetch_reggroups "fetch reggroups"] + +foreach reggroup $reggroups { + gdb_test "info reg $reggroup" ".*" "info reg $reggroup" +}