From patchwork Tue Nov 21 22:29:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 24434 Received: (qmail 38996 invoked by alias); 21 Nov 2017 22:29:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38915 invoked by uid 89); 21 Nov 2017 22:29:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=51920, dest X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 22:29:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 165E611652C; Tue, 21 Nov 2017 17:29:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dLptIh9MTyYh; Tue, 21 Nov 2017 17:29:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DA39A116523; Tue, 21 Nov 2017 17:29:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B29978745A; Tue, 21 Nov 2017 14:29:28 -0800 (PST) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Xavier Roirand Subject: [Ada 4/6] problem debugging ravenscar programs if runtime is stripped Date: Tue, 21 Nov 2017 14:29:21 -0800 Message-Id: <20171121222923.8951-5-brobecker@adacore.com> In-Reply-To: <20171121222923.8951-1-brobecker@adacore.com> References: <20171121222923.8951-1-brobecker@adacore.com> Trying to debug a program using a stripped version of the ravenscar runtime, we can get the following error: (gdb) cont Continuing. Cannot find Ada_Task_Control_Block type. Aborting This is because the ravenscar-thread layer makes the assumption that the runtime is built the way we expect it, meaning that the Ada tasking units we rely on for Ada tasking debugging, are built with debugging information, and that this debug information has not been stripped from the runtime. When this assumption is not true, resuming such a program can trigger the error above, which then leads GDB a little confused. For instance, we can see things like: (gdb) bt Target is executing. This patch fixes the issue by disabling the ravenscar thread layer if we detect that the runtime is missing some of the debugging info we need in order to support Ada task debugging. This is the best we can do, as the ravenscar-thread layer actually depends on the ada-tasks layer to implement thread debugging. gdb/ChangeLog: * ada-lang.h (ada_get_tcb_types_info): Add declaration. * ada-tasks.c (ada_get_tcb_types_info): Renames get_tcb_types_info. Make non-static. Change return type to char *. Adjust code accordingly. Rewrite the function's documentation. (read_atcb): Adjust call to get_tcb_types_info accordingly. * ravenscar-thread.c (ravenscar_inferior_created): Check that we have enough debugging information in the runtime to support Ada task debugging before we enable the ravenscar-thread layer. --- gdb/ada-lang.h | 2 ++ gdb/ada-tasks.c | 39 ++++++++++++++++++++++----------------- gdb/ravenscar-thread.c | 8 ++++++++ 3 files changed, 32 insertions(+), 17 deletions(-) diff --git a/gdb/ada-lang.h b/gdb/ada-lang.h index 36a5820ee3..0530e9aacd 100644 --- a/gdb/ada-lang.h +++ b/gdb/ada-lang.h @@ -409,6 +409,8 @@ typedef void (ada_task_list_iterator_ftype) (struct ada_task_info *task); extern void iterate_over_live_ada_tasks (ada_task_list_iterator_ftype *iterator); +extern const char *ada_get_tcb_types_info (void); + extern int ada_build_task_list (void); extern void print_ada_task_info (struct ui_out *uiout, diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c index 16cee35d86..eac6c5be91 100644 --- a/gdb/ada-tasks.c +++ b/gdb/ada-tasks.c @@ -466,18 +466,17 @@ read_fat_string_value (char *dest, struct value *val, int max_len) dest[len] = '\0'; } -/* Get from the debugging information the type description of all types - related to the Ada Task Control Block that will be needed in order to - read the list of known tasks in the Ada runtime. Also return the - associated ATCB_FIELDNOS. - - Error handling: Any data missing from the debugging info will cause - an error to be raised, and none of the return values to be set. - Users of this function can depend on the fact that all or none of the - return values will be set. */ - -static void -get_tcb_types_info (void) +/* Get, from the debugging information, the type description of all types + related to the Ada Task Control Block that are needed in order to + read the list of known tasks in the Ada runtime. If all of the info + needed to do so is found, then save that info in the module's per- + program-space data, and return NULL. Otherwise, if any information + cannot be found, leave the per-program-space data untouched, and + return an error message explaining what was missing (that error + message does NOT need to be deallocated). */ + +const char * +ada_get_tcb_types_info (void) { struct type *type; struct type *common_type; @@ -518,7 +517,7 @@ get_tcb_types_info (void) NULL).symbol; if (atcb_sym == NULL || atcb_sym->type == NULL) - error (_("Cannot find Ada_Task_Control_Block type. Aborting")); + return _("Cannot find Ada_Task_Control_Block type"); type = atcb_sym->type; } @@ -531,11 +530,11 @@ get_tcb_types_info (void) } if (common_atcb_sym == NULL || common_atcb_sym->type == NULL) - error (_("Cannot find Common_ATCB type. Aborting")); + return _("Cannot find Common_ATCB type"); if (private_data_sym == NULL || private_data_sym->type == NULL) - error (_("Cannot find Private_Data type. Aborting")); + return _("Cannot find Private_Data type"); if (entry_call_record_sym == NULL || entry_call_record_sym->type == NULL) - error (_("Cannot find Entry_Call_Record type. Aborting")); + return _("Cannot find Entry_Call_Record type"); /* Get the type for Ada_Task_Control_Block.Common. */ common_type = common_atcb_sym->type; @@ -583,6 +582,7 @@ get_tcb_types_info (void) pspace_data->atcb_ll_type = ll_type; pspace_data->atcb_call_type = call_type; pspace_data->atcb_fieldno = fieldnos; + return NULL; } /* Build the PTID of the task from its COMMON_VALUE, which is the "Common" @@ -630,7 +630,12 @@ read_atcb (CORE_ADDR task_id, struct ada_task_info *task_info) = get_ada_tasks_pspace_data (current_program_space); if (!pspace_data->initialized_p) - get_tcb_types_info (); + { + const char *err_msg = ada_get_tcb_types_info (); + + if (err_msg != NULL) + error (_("%s. Aborting"), err_msg); + } tcb_value = value_from_contents_and_address (pspace_data->atcb_type, NULL, task_id); diff --git a/gdb/ravenscar-thread.c b/gdb/ravenscar-thread.c index 83dfd9d4ad..e7922277ce 100644 --- a/gdb/ravenscar-thread.c +++ b/gdb/ravenscar-thread.c @@ -519,12 +519,20 @@ ravenscar_core_of_thread (struct target_ops *ops, ptid_t ptid) static void ravenscar_inferior_created (struct target_ops *target, int from_tty) { + const char *err_msg; if (!ravenscar_task_support || gdbarch_ravenscar_ops (target_gdbarch ()) == NULL || !has_ravenscar_runtime ()) return; + err_msg = ada_get_tcb_types_info (); + if (err_msg != NULL) + { + warning (_("%s. Task/thread support disabled.\n"), err_msg); + return; + } + ravenscar_update_inferior_ptid (); push_target (&ravenscar_ops); }