From patchwork Thu Oct 19 13:10:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 23682 Received: (qmail 6576 invoked by alias); 19 Oct 2017 13:10:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6558 invoked by uid 89); 19 Oct 2017 13:10:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:andrew X-HELO: mail-wr0-f193.google.com Received: from mail-wr0-f193.google.com (HELO mail-wr0-f193.google.com) (209.85.128.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 13:10:20 +0000 Received: by mail-wr0-f193.google.com with SMTP id p46so8274752wrb.0 for ; Thu, 19 Oct 2017 06:10:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2BfpPSMdrBwERj/KMqxKdXnl4hXr8NVYdFUVEL3Q2B8=; b=rFCj3CW6Mua/A9i/tsULPsuNwPQGkjhpffPGuZRoB15ecmIZlqkSmbzZMLa+pPWYGg YAxY+nvY0uVfAUJBOos48q285pgMffmSTS+Vj18xVtkpfPxWb9H6p1J8JdFwg9U7V5yg qQ8sKCMB0PZSfU8Sx1mHFvBNw4h0Z8T4KJ446dmin6IxEjcBP8Pd+Me0J0l8SNA9tHN/ 6MnMh9x/gnBa0txpLoWwmhiE0l5Kx/bKxI/qkmUsXM8ele/B6bYiLOS5suh94jISfis1 87IGDet+9FBVU7/xJHAd7mB9B5fav28SZlGdGU8YToXsFI0XxeVWFgwQUed/H0NcgcJO Dtdg== X-Gm-Message-State: AMCzsaXMGQzvrKxHj3mlqT2AFTGpTjUiI4+uXRwl0RNFkYN0gfOi0b9y /473ho6EFPetjbf1boxU/YvYVFzw X-Google-Smtp-Source: ABhQp+QopINx606tI0H/WcdnmL7BlY/9tTQcCNR0jN4I6ujY0jMLSlDZsCYdXwj1QRJfTf6MfB3acg== X-Received: by 10.223.134.250 with SMTP id 55mr1658616wry.249.1508418618238; Thu, 19 Oct 2017 06:10:18 -0700 (PDT) Received: from localhost (host86-135-253-165.range86-135.btcentralplus.com. [86.135.253.165]) by smtp.gmail.com with ESMTPSA id r134sm5080179wmf.3.2017.10.19.06.10.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 06:10:17 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb: Remove hard-coded line number from test Date: Thu, 19 Oct 2017 14:10:04 +0100 Message-Id: <20171019131004.14544-1-andrew.burgess@embecosm.com> X-IsSubscribed: yes Removes the use of a hard-coded line number from a test. gdb/testsuite/ChangeLog: * gdb.linespec/ls-errs.exp (do_test): Update comment, use line number from variable rather than hard-coded. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.linespec/ls-errs.exp | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.linespec/ls-errs.exp b/gdb/testsuite/gdb.linespec/ls-errs.exp index f55cd0e8e9..ee8bb087f0 100644 --- a/gdb/testsuite/gdb.linespec/ls-errs.exp +++ b/gdb/testsuite/gdb.linespec/ls-errs.exp @@ -117,10 +117,10 @@ proc do_test {lang} { foreach x $invalid_offsets { set offset $x - # Relative offsets are relative to line 16. Adjust + # Relative offsets are relative to the current line. Adjust # expected offset from error message accordingly. if {[string index $x 0] == "+" || [string index $x 0] == "-"} { - incr offset 24 + incr offset $bp_location } test_break $x invalid_offset $offset test_break "-line $x" invalid_offset $offset