From patchwork Tue Feb 28 14:50:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Rudo X-Patchwork-Id: 19398 Received: (qmail 16434 invoked by alias); 28 Feb 2017 14:50:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 16309 invoked by uid 89); 28 Feb 2017 14:50:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, KHOP_DYNAMIC, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=from_tty, gdb_stdout X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Feb 2017 14:50:23 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1SEn5Vt089026 for ; Tue, 28 Feb 2017 09:50:22 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 28wam8tbn2-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 28 Feb 2017 09:50:21 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 28 Feb 2017 14:50:20 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 28 Feb 2017 14:50:18 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 54BEA2190056 for ; Tue, 28 Feb 2017 14:49:19 +0000 (GMT) Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1SEoIq158523688; Tue, 28 Feb 2017 14:50:18 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FCBB52047; Tue, 28 Feb 2017 13:48:53 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 4E3AB52057; Tue, 28 Feb 2017 13:48:53 +0000 (GMT) From: Philipp Rudo To: gdb-patches@sourceware.org Cc: arnez@linux.vnet.ibm.com Subject: [PATCH 01/11] Remove unused deprecated_{pre|post}_add_symbol_hook Date: Tue, 28 Feb 2017 15:50:06 +0100 In-Reply-To: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> References: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022814-0040-0000-0000-000003530BA8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022814-0041-0000-0000-00001F12297E Message-Id: <20170228145016.22604-2-prudo@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-02-28_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702280136 X-IsSubscribed: yes Nobody actually uses those hooks anymore. So simply remove them. gdb/ChangeLog * defs.h (deprecated_pre_add_symbol_hook) (deprecated_post_add_symbol_hook): Remove. * symfile.c (deprecated_pre_add_symbol_hook) (deprecated_post_add_symbol_hook): Remove. (symbol_file_add_with_addrs): Adjust. --- gdb/defs.h | 2 -- gdb/symfile.c | 18 ++++-------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index aa58605..b3086b9 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -660,8 +660,6 @@ extern char *interpreter_p; struct target_waitstatus; struct cmd_list_element; -extern void (*deprecated_pre_add_symbol_hook) (const char *); -extern void (*deprecated_post_add_symbol_hook) (void); extern void (*selected_frame_level_changed_hook) (int); extern int (*deprecated_ui_loop_hook) (int signo); extern void (*deprecated_show_load_progress) (const char *section, diff --git a/gdb/symfile.c b/gdb/symfile.c index f2528fc..a749a2c 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -72,8 +72,6 @@ void (*deprecated_show_load_progress) (const char *section, unsigned long section_size, unsigned long total_sent, unsigned long total_size); -void (*deprecated_pre_add_symbol_hook) (const char *); -void (*deprecated_post_add_symbol_hook) (void); static void clear_symtab_users_cleanup (void *ignore); @@ -1174,14 +1172,9 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name, performed, or need to read an unmapped symbol table. */ if (should_print) { - if (deprecated_pre_add_symbol_hook) - deprecated_pre_add_symbol_hook (name); - else - { - printf_unfiltered (_("Reading symbols from %s..."), name); - wrap_here (""); - gdb_flush (gdb_stdout); - } + printf_unfiltered (_("Reading symbols from %s..."), name); + wrap_here (""); + gdb_flush (gdb_stdout); } syms_from_objfile (objfile, addrs, add_flags); @@ -1212,10 +1205,7 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name, if (should_print) { - if (deprecated_post_add_symbol_hook) - deprecated_post_add_symbol_hook (); - else - printf_unfiltered (_("done.\n")); + printf_unfiltered (_("done.\n")); } /* We print some messages regardless of whether 'from_tty ||