From patchwork Tue Jan 10 20:30:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 18848 Received: (qmail 44047 invoked by alias); 10 Jan 2017 20:31:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 44027 invoked by uid 89); 10 Jan 2017 20:31:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 spammy=Nowadays, Hx-spam-relays-external:sk:EUR01-D, Hx-languages-length:928, H*RU:sk:EUR01-D X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 20:31:17 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.253.124]) by (Symantec Mail Security) with SMTP id 8A.57.17130.29445785; Tue, 10 Jan 2017 21:31:14 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jan 2017 21:30:42 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by DBXPR07MB398.eurprd07.prod.outlook.com (10.141.14.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.6; Tue, 10 Jan 2017 20:30:40 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] Update comment in linux_nat_can_async_p Date: Tue, 10 Jan 2017 15:30:26 -0500 Message-ID: <20170110203026.31683-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DM5PR19CA0008.namprd19.prod.outlook.com (10.175.226.146) To DBXPR07MB398.eurprd07.prod.outlook.com (10.141.14.148) X-MS-Office365-Filtering-Correlation-Id: 1fccac0d-4c55-490b-90ca-08d439978bd1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DBXPR07MB398; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB398; 3:DrAhkcawH2MPU5cvaOYqo3e1hv7RoR/Feid3W3UFepu+BztgtqT3t1MwRu32sXxG4foLof9/UaO3JMFew/sGJshOBz90gsopVMARZ9DKjB0siz1qJsLgr5cMzXDEHLXlpS6q/aYk/u8XD9bu2VWRsJDkxt/MKJgRubGmbwPlIULXywbE4ni2WGeqGw7jc0NVxX6SVp2EJ0u3iVeGqBYgFxN0Vl/eMU6loU7AsQu/eBso/BKyItRuqq99zrOs8tlaDyIQlxkvVVWhoPT3FQPf8g==; 25:ERD0QWG3CCwOUpevvrNzlzLM9s9V7kPNSI1058znboQc204CEhP6oDM4Je13LZQCElLafGgq96DdMK2X66QmhphyAqhPxRF5zThS01q3Ag9BkGyvFYIdorqjZheafqJCzyKwI2kfOE5LjhCEuw2RVdy2OZpT1hTwdKEKZaGtmWdb3S08Mbdb6egvdEm71vM2O2NOZnSBjsKOH56tBmPYLQ9IreqXcKi0eYvu8hLYocdLVMRyPdaN9LtIYkAbw+EjyfS4zHYbwjXyKD6Bncte1mflStm3DWpiadU8rTDsIOIv8UfkAS339ncGSRpViszoCgiocD2cj8uX7gKjUgWJqveCrPpmsiZTlBNf1Sc5y1eAov4PVwrRxZo2/5jyDybH6XWaNNdGTVbAFxi8edXqh6giCiH84UvAEDYQRVyngIi8y+3vdcvknHnuqX2vsB53w9qqlK1HAria/tkKNjcBxw== X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB398; 31:SAsOneIhpbkTcm2V1A3iSnCXw36nUsOYYtySXijovmBRN/Q7iQppvFNPnXoU93tVcFpFXMu9RtBEYliDn82tNLGRik0lELI8fEtwIJIu7k0FkqYQRnOE9BTG/CC35/Qm/Vzp3q0fs9/4kLWG8e6/3TORO7Q0nYgSu5MTRslEcMjKJmyVHeXwS/P64SDlBS/WPMXIuVEAu9r73z2E077CKt6AsMccMtZNHLIcdLTLzA9iqCOJwUqN84Q1+gdqS0mmfDV+v/sLgHVoIcLwek5fmA==; 20:wcuDPoNVNQVr5z+o48zSz2Kn2IAqPTxISszBAv9hFmZhK2nCU/7PhyvJQqlaM24XUW1QmsOsCsKOTlB1FJk7VlAIWAa7/oZpAKUEuIG7i5jyaZ4daVB1AnSwm5FLgCkwXBjyq+iUzkeKFluXJEkZIRRmAkgod+U5O5K0FBs1765hs9YagdRl5W8V5pSx+SMdDMATm9Z1ICJcgFgVGBJI54HDZL2MD97jfzCFP+vRhh1EHAPAldQTZBF1ws9gY//FSzNLS/I27B3OUN+ImhrFneJpIHFMqbtx2PWGnaU1A9+v1Mt5T6HGdaGuRAnVjXCpRLPLP0Ee8lb7qnFFEcweS4c//1HSXCOEoWQEcrgLCngCMXkDWLdbHBFrYX3MY3GoRzLaxb0ot/Ea6e3bMFEybuP9YbI9K9RNHGyfK4r9l9G/T+HVrq2KUxqktM07rYZ/5C2sIOqG61uqvOh7vJDaAfz6rQnn2hBMgq8cVr0yIZHn1pfKOvNo+crWU/ctuGoe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:DBXPR07MB398; BCL:0; PCL:0; RULEID:; SRVR:DBXPR07MB398; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB398; 4:UwcK3tpCosjiQEL95beb8THm7I3KozdZQhf4ranv00d5RrtlIO8prRtaaTUniU3/dvgKvqRH2TrcgFvc7IeOGv31oKsbBcqvgv3onpZgzkB28mVxqOweucQ7K2ggKbegLltqXK3bh/RnTUpTHRpUT1+5WxVu3joVFkeOYVMKG1xAWUiP4rTte/aTUhkyEmjd46LdeuvlW7hbMRY7d49hRKKzXdPL2x2RHjGyqbT5CwrpF/M/zk7VUKd9cdLlPyjYWTHYx0wIhEzynGuGM6hREbfGjgEXPDzOpJ6PHjFUthxNg4bnByX6m9cApdynOuLOdFIg4FHs61EizDvHebfO6o7YCIWda9CWmaYW2cjl4WmefVSmq+c1XvT+BJVu1Ww1BUK/v9jMEyk4XD3TgO5rtY7jQ2CGbi2SNJwhAXlJYJU6mczM11meLyUTER2XPWes2wcfP10mDt+xnZN/CqFEtKqVUTgveys59Dz4V72MQpEOqdOsRW9pHQhaFrJPNarcfOT3+MFzZ+42Ow3g76/fO3F+ZcRd27B4IwecYSpWuYiHc/AZ0Wl3hXVtJaQ89BkxbdiUh/ss18tgcwaDPE2Gsg== X-Forefront-PRVS: 01834E39B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(54534003)(199003)(377424004)(189002)(3846002)(6116002)(106356001)(1076002)(4001430100002)(66066001)(47776003)(2351001)(25786008)(6486002)(450100001)(4326007)(92566002)(2906002)(68736007)(6916009)(6666003)(42186005)(48376002)(15650500001)(101416001)(7736002)(50466002)(305945005)(5003940100001)(50986999)(6512007)(86362001)(38730400001)(6506006)(8676002)(81166006)(105586002)(5660300001)(81156014)(33646002)(110136003)(36756003)(50226002)(97736004)(107886002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB398; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB398; 23:dELKzREHQYyHsCctJssPP5NmGuqKPmErEmCqEBNRK9?= =?us-ascii?Q?U80NVuhkArNj5kdY4vZBlcx7GWzcL3TxBupAGswPoF6ghP3oAACbkkvNl6NG?= =?us-ascii?Q?U8Pstg5INR19+lGSCgi0ViGkUI0RtgLg6IsOefeU/ezGA5MQnJz6TSTJIng0?= =?us-ascii?Q?UCULSdrJPX2Llh59vBlGythCHWEfPzs56yyldPeeE79XkkRZcEX9X6pk4hwh?= =?us-ascii?Q?R0CKCdw3KRyBTm37TIzI4QDTjzvp7gzONcb4d2dliPAbRb3TnPwr+YmA5GNv?= =?us-ascii?Q?Y9QD7fPPf8/5V8cjQ01zf1fD9G9BhS5xPj1HiHLHIJu8ofkZb5G779l4GGVp?= =?us-ascii?Q?UeptRuMnT/jGD0XtgOfTdhPDhZ3dOxVEHljJ1dxx547PVchyhjdI5837cGCS?= =?us-ascii?Q?zU8fXl5z2flQHkIjFj6u0NM+gqtAZ13Znf6erMZiZY/2wj61quFUWhYqb6M/?= =?us-ascii?Q?//nRQApQncOL3fIT3aeVqd/rICic+fQTgRawn5DA8/3uxlgOT0bcJ6eq0Vq3?= =?us-ascii?Q?AjwOkUZI/NKp8b7frF/Rgz1geOaYSFz1OqCVJ7VyWpQR5k9wcT//MBfW97Gy?= =?us-ascii?Q?VKwOSzOaCnRlMG6W1J6Pp/rlCr5hOt3RCfqFi5D5tn7R0HjBGDbRZ9TfwOLN?= =?us-ascii?Q?/1069kU6vrIStbbym6Zo3NJ8DgG3J6408+ROn/yS+hz6FU39tZueRtfnAyqs?= =?us-ascii?Q?Dk9Ilv02K276F2r3WR2IEq5cKi5UdhIRi0wCaI2nPEgufvs73+a+/peSESCo?= =?us-ascii?Q?5zmkkoYfWy62ao0dOHDuad4XPuTEiUWGAZDGFg+ONmWLkXcm0uSMS+KcwVwT?= =?us-ascii?Q?+wZSj+/N2vzlNDpWjaGjvqAbL63WnlpI7y7KzgbO5z7jcV0wtdCcSQ1VGNCL?= =?us-ascii?Q?5VOdZWY2uCyGvTdWG70GSwSCWjDnmEbRecwBqIsob9S1JKKUp8KJ2DsHeDT1?= =?us-ascii?Q?G6NZy2EhkZHAw3lT60hS3JNaWT3Y0XzF6uKRyBbf+ek43TNgOuyVNOsj1+CC?= =?us-ascii?Q?OmDlNaTGxVpdwxGSTHrktUyUfz006ZvQEW32w57G9wTg7I0gp8PZ1ykBeYiY?= =?us-ascii?Q?jnStKrhqAGLhB/ZSoxVj29XsaEsCBbw30QHlT4W1eKK7P84s3uDJ6ul+Td0l?= =?us-ascii?Q?HlwQLuOlKDbw1bfWf+CbyE9WWXVbUM1gR+uq38i0h0FTci4DtXwEmR8zM+9v?= =?us-ascii?Q?fCXohlcz0FzmdGQIOz1D6SxKX9MyI2Fz+RHyGdn9bBTFTg4EwCbJzIww=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB398; 6:rncR+scqSRV18osTIBqwoFaZGbvNkeFXsvk/oNl4VEEo+f4c5tr5SDl8qLzaTImG28FdnyOZ6FiJEMCsLOkQSmLpax2ZOuaiFUvNEPOQXs6mv5ZNX09HoLONHWKb3AWPGTh5i2R+HYDz11ylQTNkYvABCs3y6q0nFWLLZkzba0DTWl2VHoxYULpqrzlSzJojOgxxcM8T4qJXxElgN+tZpskOgYnV5w5usW8u6Cjq5VeWWC1jYSVS8YXlkBnPiY0drxKWEc88YPeII2Sq2NNu6JOvcM1UpuTSyW1marpa7z0/Z0f2lH+wbm2ZeQ9i5ViuObRST2TTTPhRVJId/gV9qo1xc78gFSvSnZx3PbNGVjt6NigqzaW4h7eFKov53rwMDCy61UcZGQDbviqpgLIVLMqd4Mur9e+heDIdFTB4z4s=; 5:tO9NWxprj/yjH65wWCy/TQyrXwetxTeBaCOfTvYMeHqiujKotVh09I+y2OtwKqHujmrwHAjaRPTws+nwmwGgfFYKR79ejyJKzi0bWZ0+sySex5vhOX/KNUhiVIqM5eao74bnZO4qHM3xdRzhBXnwpg==; 24:i9izaxXhgrNsGj627BMnUa7tZwW3lvFX/Pf9KPYl0a4Ix/EMeoFiXin50Fp0U8vp0eWmcZEybyQdVmWQUium/kl32ip7//OKcy6SmNdfuFg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB398; 7:XeLg1dNK/7YZUTqrm5eRNPHn/CPOvQyolIVn0rWZvDWfquC6khy9EHH8jEpbbL812xve6najw1oLWKylhzsjDeI07RYJ940qZFg5nln6Elq9VAPhwRBoEp9Iyy8xucyCwAklLb9vEo69d0hGiXijY0AZPrEFwX02vIgIBakDSL5UEM4Ztu4yPbf2SzvjE0lSwfwxVcXdA5THABN+3bEv57xjYm2cZZKlpoXhmIY6MkYBCsiFTqHLqr6ksjr7Ppyqs+yTDRlA9de0zLH2BhOGv59T+UKxzu3c9y78G90CEW/CAlZpFzh5ZAyLJKiWPi6ZOC2ny2DMIQ6DUmXOC3VtcrDTSnw23tsLRabKbFBPKF6fWtWSX1Z/ZdmQoqieIcXDzwStuf7MHVr91pdSRVCuyL1uqCRY9TDlgdMFzMj6/e4lhjlVIuPfQ8sghvQDF+RRAvj3hqhmb5hZDDcL5CDMCQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2017 20:30:40.9070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB398 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes I think this comment is outdated. Nowadays, linux-nat is always async, unless the user has explictly turned it off with "maint set target-async off". gdb/ChangeLog: * linux-nat.c (linux_nat_can_async_p): Update comment. --- gdb/linux-nat.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index dd5c6d2c4d..c58ed83efd 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -4417,9 +4417,8 @@ linux_nat_is_async_p (struct target_ops *ops) static int linux_nat_can_async_p (struct target_ops *ops) { - /* NOTE: palves 2008-03-21: We're only async when the user requests - it explicitly with the "set target-async" command. - Someday, linux will always be async. */ + /* We're always async, unless the user explicitly prevented it with the + "maint set target-async" command. */ return target_async_permitted; }