From patchwork Wed Dec 28 12:11:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 18719 Received: (qmail 126498 invoked by alias); 28 Dec 2016 12:11:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 126475 invoked by uid 89); 28 Dec 2016 12:11:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=H*Ad:U*macro, UD:lo, sk:3e9dc54, HX-Received:Wed X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pg0-f65.google.com Received: from mail-pg0-f65.google.com (HELO mail-pg0-f65.google.com) (74.125.83.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Dec 2016 12:11:24 +0000 Received: by mail-pg0-f65.google.com with SMTP id b1so15601538pgc.1; Wed, 28 Dec 2016 04:11:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5Ck9eHPev6CP1T0GfBIaTpvfh+B0skuTABZE8eOKHNg=; b=Gk0pldWfvgvhgB0Qo+J7kCRV8Y4ixIkSdARHxOTbUTGtmaFxc46mPsm3M2iILdJ/sS odt66s+zHr9ZDAalaNn+BId/vUl2xR5f0MKWkbYoDMeOc4ZbuPpY0bo6GGJ5XfxYknrB 8hgpQoSz8Vb9woxenSO3rdBOr71Vvs2na8qNFz/vvlI3AP2t5Q7US4dADqUMZUgA1aiF BHlmZJrSflYsZO1ZtdJzWdzCY0+HJLri1ao1W0cfjkQoBlEnp2NL8LA8a+RL5Lue1Hw/ luWGPtdrjMxv7VxPNn6mWbXMeg/17MyrQL/HPb/30NII8rhKdzJWjG2U7Td+0CDS/utj ZF6Q== X-Gm-Message-State: AIkVDXIZPd69GmEwqb7g84ipeQr04gutLnpAPbKYTSMLsqxCIngp0oE5SrLN7PrT4ppaMQ== X-Received: by 10.84.136.1 with SMTP id 1mr77562458plk.152.1482927083318; Wed, 28 Dec 2016 04:11:23 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id s3sm64801779pfg.14.2016.12.28.04.11.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Dec 2016 04:11:22 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 27917C2F84; Wed, 28 Dec 2016 22:41:18 +1030 (ACDT) Date: Wed, 28 Dec 2016 22:41:18 +1030 From: Alan Modra To: Joel Brobecker Cc: "Maciej W. Rozycki" , binutils@sourceware.org, gdb-patches@sourceware.org, Tristan Gingold Subject: Re: [PATCH, RFA] opcodes: Use autoconf to check for `bfd_mips_elf_get_abiflags' in BFD Message-ID: <20161228121117.GB29355@bubble.grove.modra.org> References: <20161215230316.GM10584@bubble.grove.modra.org> <20161222123958.GA2896@bubble.grove.modra.org> <20161227100841.25zlpfrfcl6vp3xl@adacore.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161227100841.25zlpfrfcl6vp3xl@adacore.com> User-Agent: Mutt/1.5.24 (2015-08-30) On Tue, Dec 27, 2016 at 02:08:41PM +0400, Joel Brobecker wrote: > The reason for the failure is the following change: > > -# development.sh is used to determine -Werror default. > -CONFIG_STATUS_DEPENDENCIES = $(BFDDIR)/development.sh > +# development.sh is used to determine -Werror default, libbfd.la is needed > +# for function availability checks. > +CONFIG_STATUS_DEPENDENCIES = $(BFDDIR)/development.sh ../bfd/libbfd.la > > It causes the following scenario to fail: > > $ ./configure > $ make configure-host > $ make distclean > > I'm pretty sure "./configure; make; make distclean" fails the same way, Yes, it does. So let's revert that patch and simply modify the make rule for mips-dis.lo (ie. provide it to overrided the default automake rule) to test whether elfxx-mips.c has been compiled in. The top level makefile already has the required directory dependencies. * configure.ac: Revert 2016-12-23. * Makefile.am: Likewise. (MIPS_DEFS): Define. (mips-dis.lo): Add rule. * Makefile.in: Regenerate. * aclocal.m4: Regenerate. * config.in: Regenerate. * configure: Regenerate. Diff below excludes the reversion. diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am index 3e9dc54..a441feb 100644 --- a/opcodes/Makefile.am +++ b/opcodes/Makefile.am @@ -610,6 +609,19 @@ $(srcdir)/z8k-opc.h: @MAINT@ z8kgen$(EXEEXT_FOR_BUILD) z8k-dis.lo: $(srcdir)/z8k-opc.h +MIPS_DEFS=`case \`cat ../bfd/ofiles\` in *elfxx-mips*) echo "-DHAVE_BFD_MIPS_ELF_GET_ABIFLAGS=1";; esac` +mips-dis.lo: mips-dis.c +if am__fastdepCC + $(LTCOMPILE) -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ $(MIPS_DEFS) $< + $(am__mv) $(DEPDIR)/$*.Tpo $(DEPDIR)/$*.Plo +else +if AMDEP + source='$<' object='$@' libtool=yes @AMDEPBACKSLASH@ + DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@ +endif + $(LTCOMPILE) -c -o $@ $(MIPS_DEFS) $< +endif + sh-dis.lo: sh-dis.c if am__fastdepCC $(LTCOMPILE) -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ @archdefs@ $(srcdir)/sh-dis.c