From patchwork Sun Sep 11 14:04:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 15503 Received: (qmail 125606 invoked by alias); 11 Sep 2016 14:04:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125584 invoked by uid 89); 11 Sep 2016 14:04:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1724 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Sep 2016 14:04:18 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31B7F4E4C7 for ; Sun, 11 Sep 2016 14:04:17 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-46.ams2.redhat.com [10.36.116.46]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8BE4E7J016145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 11 Sep 2016 10:04:16 -0400 Date: Sun, 11 Sep 2016 16:04:13 +0200 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Sergio Durigan Junior Subject: [testsuite patch] Fix false FAIL in stap-probe.exp Message-ID: <20160911140413.GA557@host1.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.7.0 (2016-08-17) X-IsSubscribed: yes Hi, gcc-6.2.1-1.fc26.x86_64 # Set a breakpoint with multiple probe locations. gdb_test "break -pstap test:two" \ "Breakpoint \[0-9\]+ at $hex.*2 locations.*" \ "set multi-location probe breakpoint (probe two)" break -pstap test:two^M Breakpoint 2 at 0x4004e0^M (gdb) FAIL: gdb.base/stap-probe.exp: without semaphore, optimized: set multi-location probe breakpoint (probe two) # Set a breakpoint with multiple probe locations. # In this scenario, we may expect more than 2 locations because of # the optimizations (inlining, loop unrolling, etc). gdb_test "break -pstap test:two" \ "Breakpoint .* at $hex.*\[0-9\]+ locations.*" \ "set multi-location probe breakpoint (probe two)" break -pstap test:two^M Breakpoint 2 at 0x4004e0^M (gdb) FAIL: gdb.base/stap-probe.exp: with semaphore, optimized: set multi-location probe breakpoint (probe two) OK for check-in? Jan gdb/testsuite/ChangeLog 2016-09-11 Jan Kratochvil * gdb.base/stap-probe.exp (stap_test_no_debuginfo): Try to use -fno-ipa-icf. diff --git a/gdb/testsuite/gdb.base/stap-probe.exp b/gdb/testsuite/gdb.base/stap-probe.exp index df46e80..9258926 100644 --- a/gdb/testsuite/gdb.base/stap-probe.exp +++ b/gdb/testsuite/gdb.base/stap-probe.exp @@ -97,8 +97,11 @@ proc stap_test_no_debuginfo {exec_name {arg ""}} { global testfile hex if {[prepare_for_testing ${testfile}.exp ${exec_name} ${testfile}.c \ - {$arg nodebug optimize=-O2}]} { - return -1 + {$arg nodebug optimize=-O2 "additional_flags=-fno-ipa-icf"}]} { + if {[prepare_for_testing ${testfile}.exp ${exec_name} ${testfile}.c \ + {$arg nodebug optimize=-O2}]} { + return -1 + } } if {[runto "-pstap test:user"]} {