From patchwork Fri Apr 8 15:53:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 11674 Received: (qmail 117883 invoked by alias); 8 Apr 2016 15:53:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117867 invoked by uid 89); 8 Apr 2016 15:53:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Apr 2016 15:53:36 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CF4CC049D5C; Fri, 8 Apr 2016 15:53:35 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u38FrWSF007287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Apr 2016 11:53:34 -0400 Date: Fri, 8 Apr 2016 17:53:31 +0200 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Markus Metzger Subject: [testsuite patch] Fix gdb.btrace/tailcall-only.exp errors on x86_64-m32 Message-ID: <20160408155331.GA31979@host1.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes Hi, $ runtest 'CC_FOR_TARGET=gcc -m32' gdb.btrace/tailcall-only.exp Running ./gdb.btrace/tailcall-only.exp ... gdb compile failed, tailcall-only.c: Assembler messages: tailcall-only.c:142: Error: cannot represent relocation type BFD_RELOC_64 [...] tailcall-only.c:425: Error: cannot represent relocation type BFD_RELOC_64 It works for the other x86 arch combinations: --- 20160406clean63-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m32.sum 2016-04-06 17:44:45.262849875 +0200 +++ 20160408clean67-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m32.sum 2016-04-08 17:40:49.739742759 +0200 #gdb.btrace/tailcall-only.exp +Running gdb/testsuite/gdb.btrace/tailcall-only.exp ... +gdb compile failed, tailcall-only.c: Assembler messages: +tailcall-only.c:142: Error: cannot represent relocation type BFD_RELOC_64 [...] +tailcall-only.c:425: Error: cannot represent relocation type BFD_RELOC_64 +UNTESTED: gdb.btrace/tailcall-only.exp: tailcall-only.exp --- 20160406clean63-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m64.sum 2016-04-06 17:44:45.555852344 +0200 +++ 20160408clean67-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m64.sum 2016-04-08 17:40:50.021744759 +0200 #gdb.btrace/tailcall-only.exp +Running gdb/testsuite/gdb.btrace/tailcall-only.exp ... +PASS: gdb.btrace/tailcall-only.exp: set record function-call-history-size 0 [...] +PASS: gdb.btrace/tailcall-only.exp: info frame --- 20160406clean63-fedora-rawhide//fedora-rawhide-i386/out/gdb-i686-redhat-linux-gnu-m32.sum 2016-04-06 17:43:44.152334900 +0200 +++ 20160408clean67-fedora-rawhide//fedora-rawhide-i386/out/gdb-i686-redhat-linux-gnu-m32.sum 2016-04-08 17:40:04.451421514 +0200 #gdb.btrace/tailcall-only.exp +Running gdb/testsuite/gdb.btrace/tailcall-only.exp ... +PASS: gdb.btrace/tailcall-only.exp: set record function-call-history-size 0 [...] +PASS: gdb.btrace/tailcall-only.exp: info frame OK for check-in? Jan gdb/testsuite/ChangeLog 2016-04-08 Jan Kratochvil * gdb.btrace/tailcall-only.exp: Use is_lp64_target check. diff --git a/gdb/testsuite/gdb.btrace/tailcall-only.exp b/gdb/testsuite/gdb.btrace/tailcall-only.exp index 44501f5..50837bf 100644 --- a/gdb/testsuite/gdb.btrace/tailcall-only.exp +++ b/gdb/testsuite/gdb.btrace/tailcall-only.exp @@ -35,9 +35,9 @@ if [info exists COMPILE] { # make check RUNTESTFLAGS="gdb.btrace/tailcall-only.exp COMPILE=1" standard_testfile tailcall-only.c lappend opts debug optimize=-O2 -} elseif {[istarget "x86_64-*-*"]} { +} elseif {[istarget "x86_64-*-*"] && [is_lp64_target]} { standard_testfile x86_64-tailcall-only.S -} elseif {[istarget "i?86-*-*"]} { +} elseif {[istarget "i?86-*-*"] || [istarget "x86_64-*-*"]} { standard_testfile i686-tailcall-only.S } else { verbose "Skipping ${testfile}."