From patchwork Wed Apr 6 19:09:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 11655 Received: (qmail 129525 invoked by alias); 6 Apr 2016 19:09:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129505 invoked by uid 89); 6 Apr 2016 19:09:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=transferred X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 Apr 2016 19:09:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C5761C049E1E for ; Wed, 6 Apr 2016 19:09:09 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u36J96il023822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 6 Apr 2016 15:09:08 -0400 Date: Wed, 6 Apr 2016 21:09:05 +0200 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Gary Benson Subject: [revert] [patchv4] Workaround gdbserver<7.7 for setfs Message-ID: <20160406190905.GA16036@host1.jankratochvil.net> References: <56F14F1E.5010606@redhat.com> <20160323211547.GA17400@host1.jankratochvil.net> <20160324220933.GA27445@host1.jankratochvil.net> <20160324223241.GB2548@host1.jankratochvil.net> <56FBDFE7.90203@redhat.com> <20160404211406.GA32241@host1.jankratochvil.net> <5703E7FF.6060304@redhat.com> <20160406134911.GA30545@host1.jankratochvil.net> <57051DAB.7000008@redhat.com> <20160406151925.GA17174@host1.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160406151925.GA17174@host1.jankratochvil.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes Hi, it no longer transferred any files with old gdbserver after this commit. (I do not have setup a regression testsuite for old gdbserver.) Therefore reverting it - as it may be breaking currently working functionalities with old gdbservers - and the workaround may get reimplemented some other way later. Jan It broke the compatibility with gdbserver-7.6 due to: warning: remote target does not support file transfer, attempting to access files from local filesystem. gdb/ChangeLog 2016-04-06 Jan Kratochvil Revert the previous commit adding unknown_v_replies_ok. --- gdb/ChangeLog | 4 ++++ gdb/remote.c | 31 ------------------------------- 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e3848ec..0af0c79 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-04-06 Jan Kratochvil + Revert the previous commit adding unknown_v_replies_ok. + +2016-04-06 Jan Kratochvil + * remote.c (struct remote_state): New field unknown_v_replies_ok. (packet_config_support): Read it. (remote_start_remote): Set it. diff --git a/gdb/remote.c b/gdb/remote.c index ea7f5b8..5c407b6 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -426,15 +426,6 @@ struct remote_state request/reply nature of the RSP. We only cache data for a single file descriptor at a time. */ struct readahead_cache readahead_cache; - - /* gdbserver < 7.7 (before its fix from 2013-12-11) did reply to any - unknown 'v' packet with string "OK". "OK" gets interpreted by GDB - as a reply to known packet. For packet "vFile:setfs:" it is an - invalid reply and GDB would return error in - remote_hostio_set_filesystem, making remote files access impossible. - If this variable is non-zero it means the remote gdbserver is buggy - and any not yet detected packets are assumed as unsupported. */ - int unknown_v_replies_ok; }; /* Private data that we'll store in (struct thread_info)->private. */ @@ -1528,13 +1519,6 @@ packet_config_support (struct packet_config *config) case AUTO_BOOLEAN_FALSE: return PACKET_DISABLE; case AUTO_BOOLEAN_AUTO: - { - struct remote_state *rs = get_remote_state (); - - if (rs->unknown_v_replies_ok && config->name != NULL - && config->name[0] == 'v') - return PACKET_DISABLE; - } return config->support; default: gdb_assert_not_reached (_("bad switch")); @@ -4039,21 +4023,6 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p) if (packet_support (PACKET_QAllow) != PACKET_DISABLE) remote_set_permissions (target); - /* See unknown_v_replies_ok description. */ - { - const char v_mustreplyempty[] = "vMustReplyEmpty"; - - putpkt (v_mustreplyempty); - getpkt (&rs->buf, &rs->buf_size, 0); - if (strcmp (rs->buf, "OK") == 0) - rs->unknown_v_replies_ok = 1; - else if (strcmp (rs->buf, "") == 0) - rs->unknown_v_replies_ok = 0; - else - error (_("Remote replied unexpectedly to '%s': %s"), v_mustreplyempty, - rs->buf); - } - /* Next, we possibly activate noack mode. If the QStartNoAckMode packet configuration is set to AUTO,