From patchwork Mon Nov 16 21:58:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 9693 X-Patchwork-Delegate: vapier@gentoo.org Received: (qmail 82716 invoked by alias); 16 Nov 2015 21:58:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 82707 invoked by uid 89); 16 Nov 2015 21:58:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 16 Nov 2015 21:58:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4223F552E8 for ; Mon, 16 Nov 2015 21:58:09 +0000 (UTC) Received: from pinnacle.lan (ovpn-113-161.phx2.redhat.com [10.3.113.161]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAGLw8I4022422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO) for ; Mon, 16 Nov 2015 16:58:09 -0500 Date: Mon, 16 Nov 2015 14:58:07 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [PATCH] PPC sim: Don't close file descriptors 0, 1, or 2 Message-ID: <20151116145807.4aedd84f@pinnacle.lan> MIME-Version: 1.0 X-IsSubscribed: yes In my testing, this patch eliminates all of the "unresolved testcases" when testing GDB against the powerpc simulator. E.g. for gdb.base.exp, I see this in the log file: (gdb) next 66 return (value); /* set breakpoint 19 here */ (gdb) PASS: gdb.base/break.exp: next over recursive call backtrace #0 factorial (value=120) at testsuite/gdb.base/break.c:66 #1 0x10000428 in factorial (value=6) at testsuite/gdb.base/break.c:64 #2 0x10000370 in main (argc=1, argv=0xdfffee20, envp=0xdfffee28) at testsuite/gdb.base/break.c:47 (gdb) PASS: gdb.base/break.exp: backtrace from factorial(5.1) continue Continuing. 720 ERROR: Process no longer exists UNRESOLVED: gdb.base/break.exp: continue until exit at recursive next test With this patch/change in place, this bit of the test runs as expected: (gdb) next 66 return (value); /* set breakpoint 19 here */ (gdb) PASS: gdb.base/break.exp: next over recursive call backtrace #0 factorial (value=120) at testsuite/gdb.base/break.c:66 #1 0x10000428 in factorial (value=6) at testsuite/gdb.base/break.c:64 #2 0x10000370 in main (argc=1, argv=0xdfffee20, envp=0xdfffee28) at testsuite/gdb.base/break.c:47 (gdb) PASS: gdb.base/break.exp: backtrace from factorial(5.1) continue Continuing. 720 [Inferior 1 (process 42000) exited normally] This occurs because the powerpc simulator closes, on behalf of the testcase, the file descriptors associated with stdin, stdout, and stderr. GDB still needs these descriptors to communicate with the user or, in this case, with the testing framework. sim/ppc/ChangeLog: * emul_netbsd.c (do_close): Don't close file descriptors 0, 1, or 2. --- sim/ppc/emul_netbsd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sim/ppc/emul_netbsd.c b/sim/ppc/emul_netbsd.c index 6bef370..5e39975 100644 --- a/sim/ppc/emul_netbsd.c +++ b/sim/ppc/emul_netbsd.c @@ -440,8 +440,13 @@ do_close(os_emul_data *emul, SYS(close); - /* Can't combine these statements, cuz close sets errno. */ - status = close(d); + /* Do not close stdin, stdout, or stderr. GDB may still need access to + these descriptors. */ + if (d == 0 || d == 1 || d == 2) + status = 0; + else + status = close(d); + emul_write_status(processor, status, errno); }