From patchwork Sun Oct 25 11:08:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 9359 Received: (qmail 81111 invoked by alias); 25 Oct 2015 11:08:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 81097 invoked by uid 89); 25 Oct 2015 11:08:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 25 Oct 2015 11:08:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0BEA2227; Sun, 25 Oct 2015 11:08:23 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9PB8J75030986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 25 Oct 2015 07:08:21 -0400 Date: Sun, 25 Oct 2015 12:08:18 +0100 From: Jan Kratochvil To: Joel Brobecker Cc: Pierre-Marie de Rodat , gdb-patches@sourceware.org Subject: [patch] Fix access_to_packed_array.exp typos/errors [Re: [PATCH] [Ada] Fix the evaluation of access to packed array subscript] Message-ID: <20151025110818.GA25554@host1.jankratochvil.net> References: <1442237665-9848-1-git-send-email-derodat@adacore.com> <20150914141800.GA10154@adacore.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150914141800.GA10154@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Mon, 14 Sep 2015 16:18:00 +0200, Joel Brobecker wrote: > > * gdb.ada/access_to_packed_array.exp: New testcase. > > Looks good to me. Please go ahead and push. Running ./gdb.ada/access_to_packed_array.exp ... ERROR: tcl error sourcing ./gdb.ada/access_to_packed_array.exp. ERROR: extra characters after close-quote while executing "gdb_test "print pack.a" "\\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)")" (file "./gdb.ada/access_to_packed_array.exp" line 29) invoked from within "source ./gdb.ada/access_to_packed_array.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source ./gdb.ada/access_to_packed_array.exp" invoked from within "catch "uplevel #0 source $test_file_name"" Attaching a fix of the typos. Unrelated to the typos I have changed the print expectations s/"x"/" = x"/ as for example expectation "3" should not match " = 43". On Fedora 21 x86_64 it then: # of expected passes 5 OK for check-in? Jan gdb/testsuite/ChangeLog 2015-10-25 Jan Kratochvil * gdb.ada/access_to_packed_array.exp: Fix typos erroring the testfile. diff --git a/gdb/testsuite/gdb.ada/access_to_packed_array.exp b/gdb/testsuite/gdb.ada/access_to_packed_array.exp index 0dca780..1bf3e22 100644 --- a/gdb/testsuite/gdb.ada/access_to_packed_array.exp +++ b/gdb/testsuite/gdb.ada/access_to_packed_array.exp @@ -26,8 +26,8 @@ clean_restart ${testfile} set bp_location [gdb_get_line_number "BREAK" ${testdir}/foo.adb] runto "foo.adb:$bp_location" -gdb_test "print pack.a" "\\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)") -gdb_test "pack.aa" "\\(access pack\\.array_type\\) 0x.* ") +gdb_test "print pack.a" " = \\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)" +gdb_test "print pack.aa" " = \\(access pack\\.array_type\\) 0x.* " -gdb_test "pack.a(2)" "3" -gdb_test "pack.aa(2)" "3" +gdb_test "print pack.a(2)" " = 3" +gdb_test "print pack.aa(2)" " = 3"