From patchwork Thu Aug 27 17:39:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Weigand X-Patchwork-Id: 8486 Received: (qmail 68832 invoked by alias); 27 Aug 2015 17:40:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68203 invoked by uid 89); 27 Aug 2015 17:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 27 Aug 2015 17:40:14 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Aug 2015 18:40:10 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 27 Aug 2015 18:40:09 +0100 X-MailFrom: uweigand@de.ibm.com X-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7397D1B0805F for ; Thu, 27 Aug 2015 18:41:41 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7RHe5jU30736544 for ; Thu, 27 Aug 2015 17:40:08 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7RHduVP001395 for ; Thu, 27 Aug 2015 11:39:56 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-24.boeblingen.de.ibm.com [9.152.213.24]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t7RHduZT001174; Thu, 27 Aug 2015 11:39:56 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 5418539FA; Thu, 27 Aug 2015 19:39:47 +0200 (CEST) Subject: Re: Cell multi-arch broken (Re: [PATCH 2/2] GNU/Linux: Stop using libthread_db/td_ta_thr_iter) To: palves@redhat.com (Pedro Alves) Date: Thu, 27 Aug 2015 19:39:47 +0200 (CEST) From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <55DE16A7.8060401@redhat.com> from "Pedro Alves" at Aug 26, 2015 08:42:31 PM MIME-Version: 1.0 Message-Id: <20150827173947.5418539FA@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15082717-0025-0000-0000-0000069FE722 Pedro Alves wrote: > On 08/26/2015 08:01 PM, Ulrich Weigand wrote: > > Pedro Alves wrote: > > >> (Sounds like the testsuite could be improved to better detect this.) > > > > Yes, I think I'll at least set the test case to UNRESOLVED if > > something unexpected happens while attempting to detect whether > > we have Cell/B.E. hardware. > > Sounds good to me. I've pushed the testcase change (see patch below) ... > >> find_one_thread makes use of td_ta_map_lwp2thr for the > >> mapping we're after. > >> On the GDB side, the equivalent is linux-thread-db.c:thread_from_lwp. > > > > Ah, indeed that works for me. The attached patch also fixes the > > problem for me. > > > > LGTM. ... and this linux-thread-db fix now. Thanks, Ulrich testsuite/ChangeLog: * lib/cell.exp (skip_cell_tests): Report UNRESOLVED on unexpected failures to run the test program under GDB. Index: binutils-gdb/gdb/testsuite/lib/cell.exp =================================================================== --- binutils-gdb.orig/gdb/testsuite/lib/cell.exp +++ binutils-gdb/gdb/testsuite/lib/cell.exp @@ -139,7 +139,7 @@ gdb_caching_proc skip_cell_tests { set result 1 } default { - verbose -log "\n$me Cell/B.E. hardware not detected (default case)" + unresolved "$me: unexpected failure" set result 1 } }