Message ID | 20150714175127.GA10807@host1.jankratochvil.net |
---|---|
State | New, archived |
Headers |
Received: (qmail 119215 invoked by alias); 14 Jul 2015 17:51:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119206 invoked by uid 89); 14 Jul 2015 17:51:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Jul 2015 17:51:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B8BC5C1F91 for <gdb-patches@sourceware.org>; Tue, 14 Jul 2015 17:51:30 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6EHpRaX021236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <gdb-patches@sourceware.org>; Tue, 14 Jul 2015 13:51:30 -0400 Date: Tue, 14 Jul 2015 19:51:27 +0200 From: Jan Kratochvil <jan.kratochvil@redhat.com> To: gdb-patches@sourceware.org Subject: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo Message-ID: <20150714175127.GA10807@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes |
Commit Message
Jan Kratochvil
July 14, 2015, 5:51 p.m. UTC
gdb/testsuite/ChangeLog 2015-07-14 Jan Kratochvil <jan.kratochvil@redhat.com> * gdb.arch/i386-biarch-core.exp: Fix comment typo. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
Comments
On 07/14/2015 02:51 PM, Jan Kratochvil wrote: > > ForwardedMessage.eml > > Subject: > [PATCH] i386-biarch-core.exp: Fix comment typo > From: > Jan Kratochvil <jan.kratochvil@redhat.com> > Date: > 07/14/2015 02:50 PM > > > gdb/testsuite/ChangeLog > 2015-07-14 Jan Kratochvil<jan.kratochvil@redhat.com> > > * gdb.arch/i386-biarch-core.exp: Fix comment typo. > --- > gdb/testsuite/ChangeLog | 4 ++++ > gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 47c1e9b..5e8b930 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,7 @@ > +2015-07-14 Jan Kratochvil<jan.kratochvil@redhat.com> > + > + * gdb.arch/i386-biarch-core.exp: Fix comment typo. > + > 2015-07-14 Pedro Alves<palves@redhat.com> > > * gdb.base/killed-outside.exp: New file. > diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp > index 612b4d8..60d049b 100644 > --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp > +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp > @@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir > # Wrongly built GDB complains by: > # "..." is not a core dump: File format not recognized > # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it. > -# This is just a problem of the test care, real-world elf64-i386 file will have > +# This is just a problem of the test case, real-world elf64-i386 file will have > # 32bit PRSTATUS. One cannot prepare elf64-i386 core file from elf32-i386 by > # objcopy as it corrupts the core file beyond all recognition. > gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file" > -- 2.1.0 > I noticed this test is running for MIPS (and probably other non-i386 targets). Was it really your intention to have this test execute on non-i386 targets?
On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote: > I noticed this test is running for MIPS (and probably other non-i386 > targets). Was it really your intention to have this test execute on non-i386 > targets? Yes, it was the intention (not in every configuration - depending on what secondary targets are supported on that host). We were discussing it in the thread: https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html I have verified now that on ppc64-rhel-7.1 it PASSes. I do not have MIPS handy, though. Could you at least post your MIPS gdb.log? Thanks, Jan
On 09/15/2015 11:22 AM, Jan Kratochvil wrote: > On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote: >> I noticed this test is running for MIPS (and probably other non-i386 >> targets). Was it really your intention to have this test execute on non-i386 >> targets? > > Yes, it was the intention (not in every configuration - depending on what > secondary targets are supported on that host). > > We were discussing it in the thread: > https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html > > I have verified now that on ppc64-rhel-7.1 it PASSes. I do not have MIPS > handy, though. Could you at least post your MIPS gdb.log? I'm seeing this: core-file gdb.arch/i386-biarch-core.core gdb/mips-tdep.c:1098: internal-error: bad register size A problem internal to GDB has been detected, further debugging may prove unreliable.^ Quit this debugging session? (y or n) FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error)
On 09/15/2015 11:29 AM, Luis Machado wrote: > On 09/15/2015 11:22 AM, Jan Kratochvil wrote: >> On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote: >>> I noticed this test is running for MIPS (and probably other non-i386 >>> targets). Was it really your intention to have this test execute on >>> non-i386 >>> targets? >> >> Yes, it was the intention (not in every configuration - depending on what >> secondary targets are supported on that host). >> >> We were discussing it in the thread: >> https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html >> >> I have verified now that on ppc64-rhel-7.1 it PASSes. I do not have MIPS >> handy, though. Could you at least post your MIPS gdb.log? > > I'm seeing this: > > core-file gdb.arch/i386-biarch-core.core > gdb/mips-tdep.c:1098: internal-error: bad register size > A problem internal to GDB has been detected, > further debugging may prove unreliable.^ > Quit this debugging session? (y or n) > FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error) > The lines are a bit off, but basically we end up hitting the internal error at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS backend is currently crafted to handle reading unknown register blocks.
On Tue, 15 Sep 2015 16:35:28 +0200, Luis Machado wrote: > On 09/15/2015 11:29 AM, Luis Machado wrote: > >core-file gdb.arch/i386-biarch-core.core > >gdb/mips-tdep.c:1098: internal-error: bad register size > >A problem internal to GDB has been detected, > >further debugging may prove unreliable.^ > >Quit this debugging session? (y or n) > >FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error) > > The lines are a bit off, but basically we end up hitting the internal error > at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS backend is > currently crafted to handle reading unknown register blocks. Then it is a mips-tdep.c bug similar to this i386-tdep.c bug: https://sourceware.org/bugzilla/show_bug.cgi?id=17808 In general GDB should not crash when you let it read an arbitrary file. If you want I can file it as a new MIPS-specific PR and KFAIL it. Jan
On 09/15/2015 11:37 AM, Jan Kratochvil wrote: > On Tue, 15 Sep 2015 16:35:28 +0200, Luis Machado wrote: >> On 09/15/2015 11:29 AM, Luis Machado wrote: >>> core-file gdb.arch/i386-biarch-core.core >>> gdb/mips-tdep.c:1098: internal-error: bad register size >>> A problem internal to GDB has been detected, >>> further debugging may prove unreliable.^ >>> Quit this debugging session? (y or n) >>> FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error) >> >> The lines are a bit off, but basically we end up hitting the internal error >> at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS backend is >> currently crafted to handle reading unknown register blocks. > > Then it is a mips-tdep.c bug similar to this i386-tdep.c bug: > https://sourceware.org/bugzilla/show_bug.cgi?id=17808 > > In general GDB should not crash when you let it read an arbitrary file. > > If you want I can file it as a new MIPS-specific PR and KFAIL it. Yes, thanks. That would be helpful. No need to KFAIL it though. It should be fixed soon.
On Tue, 15 Sep 2015 16:51:16 +0200, Luis Machado wrote: > On 09/15/2015 11:37 AM, Jan Kratochvil wrote: > >Then it is a mips-tdep.c bug similar to this i386-tdep.c bug: > > https://sourceware.org/bugzilla/show_bug.cgi?id=17808 > > > >In general GDB should not crash when you let it read an arbitrary file. > > > >If you want I can file it as a new MIPS-specific PR and KFAIL it. > > Yes, thanks. That would be helpful. No need to KFAIL it though. It should be > fixed soon. [mips] 7.9 regression: internal-error: mips-tdep.c:1098: bad register size https://sourceware.org/bugzilla/show_bug.cgi?id=18964
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 47c1e9b..5e8b930 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2015-07-14 Jan Kratochvil <jan.kratochvil@redhat.com> + + * gdb.arch/i386-biarch-core.exp: Fix comment typo. + 2015-07-14 Pedro Alves <palves@redhat.com> * gdb.base/killed-outside.exp: New file. diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp index 612b4d8..60d049b 100644 --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp @@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir # Wrongly built GDB complains by: # "..." is not a core dump: File format not recognized # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it. -# This is just a problem of the test care, real-world elf64-i386 file will have +# This is just a problem of the test case, real-world elf64-i386 file will have # 32bit PRSTATUS. One cannot prepare elf64-i386 core file from elf32-i386 by # objcopy as it corrupts the core file beyond all recognition. gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"