From patchwork Mon Mar 23 22:52:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 5770 Received: (qmail 25174 invoked by alias); 23 Mar 2015 22:52:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25159 invoked by uid 89); 23 Mar 2015 22:52:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Mar 2015 22:52:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BB76BD3623; Mon, 23 Mar 2015 18:52:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wwqbqr0dEitl; Mon, 23 Mar 2015 18:52:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 66E801163E6; Mon, 23 Mar 2015 18:52:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DFCE840EAD; Mon, 23 Mar 2015 15:52:09 -0700 (PDT) Date: Mon, 23 Mar 2015 15:52:09 -0700 From: Joel Brobecker To: Yurij Grechishhev Cc: gdb-patches@sourceware.org Subject: pushed: Re: Setting parity for remote serial Message-ID: <20150323225209.GJ5438@adacore.com> References: <20131004073447.GB3326@adacore.com> <20150225151646.GA30181@adacore.com> <20150227081642.GE31815@adacore.com> <20150317145620.GB7494@adacore.com> <83zj73rain.fsf@gnu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) > Updated patch is attached. Thanks! I noticed that there was still a slight indentation error in the calls to internal_warning, so I set about to fix those before committing the patch for you. That's when I noticed that the ChangeLog entries would not apply, and this, combined with enhancing a bit the revision log to include that ChangeLog info, distracted me enough that I forgot to fix the indentation issues! So, attached is: first, the patch that you sent, with the revision log a little augmented to make it a little more descriptive about what the patch brings in; second, the indentation fixes, applied separately, unfortunately. gdb/ChangeLog: * ser-mingw.c (ser_windows_setparity): Fix indentation. * ser-unix.c (hardwire_setparity): Likewise. I pushed the patch for you because I suspect you do not have write permissions in GDB yet, and also to minimize the ping-pong effect. I think you've worked hard on cleaning that patch up already! If you think you might have other changes you'd like to contribute, it might make sense for you to get write-after-approval privileges. If you are interested, send me a private email and I'll get you started (let me know if you have a sourceware.org account already or not). Thanks again for the patch! From 2c8f6f16bdd7cc23cbdab1889074c004667555dc Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 23 Mar 2015 15:42:23 -0700 Subject: [PATCH] Fix indentation in ser_windows_setparity and hardwire_setparity. gdb/ChangeLog: * ser-mingw.c (ser_windows_setparity): Fix indentation. * ser-unix.c (hardwire_setparity): Likewise. --- gdb/ChangeLog | 5 +++++ gdb/ser-mingw.c | 2 +- gdb/ser-unix.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e5e9255..77de88a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2015-03-23 Joel Brobecker + + * ser-mingw.c (ser_windows_setparity): Fix indentation. + * ser-unix.c (hardwire_setparity): Likewise. + 2015-03-23 Yurij Grechishhev * NEWS: Mention set/show serial parity command. diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c index 6d383ac..a6ec374 100644 --- a/gdb/ser-mingw.c +++ b/gdb/ser-mingw.c @@ -223,7 +223,7 @@ ser_windows_setparity (struct serial *scb, int parity) break; default: internal_warning (__FILE__, __LINE__, - "Incorrect parity value: %d", parity); + "Incorrect parity value: %d", parity); return -1; } diff --git a/gdb/ser-unix.c b/gdb/ser-unix.c index 280fb6a..356e5e7 100644 --- a/gdb/ser-unix.c +++ b/gdb/ser-unix.c @@ -918,7 +918,7 @@ hardwire_setparity (struct serial *scb, int parity) break; default: internal_warning (__FILE__, __LINE__, - "Incorrect parity value: %d", parity); + "Incorrect parity value: %d", parity); return -1; } -- 1.9.1