diff mbox

pushed: Re: Setting parity for remote serial

Message ID 20150323225209.GJ5438@adacore.com
State Committed
Headers

Commit Message

Joel Brobecker March 23, 2015, 10:52 p.m. UTC 
  > Updated patch is attached.

Thanks! I noticed that there was still a slight indentation error
in the calls to internal_warning, so I set about to fix those before
committing the patch for you. That's when I noticed that the ChangeLog
entries would not apply, and this, combined with enhancing a bit
the revision log to include that ChangeLog info, distracted me enough
that I forgot to fix the indentation issues!

So, attached is: first, the patch that you sent, with the revision
log a little augmented to make it a little more descriptive about
what the patch brings in; second, the indentation fixes, applied
separately, unfortunately.

gdb/ChangeLog:

        * ser-mingw.c (ser_windows_setparity): Fix indentation.
        * ser-unix.c (hardwire_setparity): Likewise.

I pushed the patch for you because I suspect you do not have
write permissions in GDB yet, and also to minimize the ping-pong
effect. I think you've worked hard on cleaning that patch up already!

If you think you might have other changes you'd like to contribute,
it might make sense for you to get write-after-approval privileges.
If you are interested, send me a private email and I'll get you
started (let me know if you have a sourceware.org account already
or not).

Thanks again for the patch!
diff mbox

Patch

From 2c8f6f16bdd7cc23cbdab1889074c004667555dc Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 23 Mar 2015 15:42:23 -0700
Subject: [PATCH] Fix indentation in ser_windows_setparity and
 hardwire_setparity.

gdb/ChangeLog:

        * ser-mingw.c (ser_windows_setparity): Fix indentation.
        * ser-unix.c (hardwire_setparity): Likewise.
---
 gdb/ChangeLog   | 5 +++++
 gdb/ser-mingw.c | 2 +-
 gdb/ser-unix.c  | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e5e9255..77de88a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2015-03-23  Joel Brobecker  <brobecker@adacore.com>
+
+	* ser-mingw.c (ser_windows_setparity): Fix indentation.
+	* ser-unix.c (hardwire_setparity): Likewise.
+
 2015-03-23  Yurij Grechishhev  <yurij.grechishhev@gmail.com>
 
 	* NEWS: Mention set/show serial parity command.
diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c
index 6d383ac..a6ec374 100644
--- a/gdb/ser-mingw.c
+++ b/gdb/ser-mingw.c
@@ -223,7 +223,7 @@  ser_windows_setparity (struct serial *scb, int parity)
       break;
     default:
       internal_warning (__FILE__, __LINE__,
-                  "Incorrect parity value: %d", parity);
+			"Incorrect parity value: %d", parity);
       return -1;
     }
 
diff --git a/gdb/ser-unix.c b/gdb/ser-unix.c
index 280fb6a..356e5e7 100644
--- a/gdb/ser-unix.c
+++ b/gdb/ser-unix.c
@@ -918,7 +918,7 @@  hardwire_setparity (struct serial *scb, int parity)
       break;
     default:
       internal_warning (__FILE__, __LINE__,
-                  "Incorrect parity value: %d", parity);
+			"Incorrect parity value: %d", parity);
       return -1;
     }
 
-- 
1.9.1