From patchwork Sat Jan 24 14:15:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 4793 Received: (qmail 21032 invoked by alias); 24 Jan 2015 14:15:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21008 invoked by uid 89); 24 Jan 2015 14:15:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 24 Jan 2015 14:15:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0OEFJRo022537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 24 Jan 2015 09:15:19 -0500 Received: from blokker.wildebeest.org (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0OEFHw7005923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 24 Jan 2015 09:15:19 -0500 Received: by blokker.wildebeest.org (Postfix, from userid 1000) id 7D2EB2073F; Sat, 24 Jan 2015 15:15:17 +0100 (CET) Date: Sat, 24 Jan 2015 15:15:17 +0100 From: Mark Wielaard To: GDB Administrator Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Sat Jan 24 01:55:33 UTC 2015 Message-ID: <20150124141517.GB19834@blokker.redhat.com> References: <20150124015533.GA15183@sourceware.org> <20150124141250.GA19834@blokker.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150124141250.GA19834@blokker.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) On Sat, Jan 24, 2015 at 03:12:50PM +0100, Mark Wielaard wrote: > Hi, > > On Sat, Jan 24, 2015 at 01:55:34AM +0000, GDB Administrator wrote: > > 645a646 > > > gdb/stack.c:2467: gettext: _ markup: All messages should be marked up with _. > > gdb/stack.c:2467: warning ("Function does not return normally to caller."); > > I think that is caused by my patch and the fix seems to simply add the _ > as attached. OK to push? Sorry, forgot to attach. Now it is. > How do I run these ARI checks locally? And could the buildbot do them? > > Thanks, > > Mark From 0ad193d0a8b80fbf32717ee7f88288f7552b12de Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sat, 24 Jan 2015 15:08:32 +0100 Subject: [PATCH] Fix ARI warning in stack.c (return_command). gdb/ChangeLog * stack.c (return_command): Markup warning message with _. --- gdb/ChangeLog | 4 ++++ gdb/stack.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 10c3855..6b89515 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-01-24 Mark Wielaard + + * stack.c (return_command): Markup warning message with _. + 2015-01-23 Simon Marchi PR gdb/17416 diff --git a/gdb/stack.c b/gdb/stack.c index 5f2a3dc..5831999 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -2464,7 +2464,7 @@ return_command (char *retval_exp, int from_tty) else { if (TYPE_NO_RETURN (thisfun->type)) - warning ("Function does not return normally to caller."); + warning (_("Function does not return normally to caller.")); confirmed = query (_("%sMake %s return now? "), query_prefix, SYMBOL_PRINT_NAME (thisfun)); }