diff mbox

New ARI warning Sat Jan 24 01:55:33 UTC 2015

Message ID 20150124141517.GB19834@blokker.redhat.com
State New
Headers show

Commit Message

Mark Wielaard Jan. 24, 2015, 2:15 p.m. UTC 
On Sat, Jan 24, 2015 at 03:12:50PM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Sat, Jan 24, 2015 at 01:55:34AM +0000, GDB Administrator wrote:
> > 645a646
> > > gdb/stack.c:2467: gettext: _ markup: All messages should be marked up with _.
> > gdb/stack.c:2467:	    warning ("Function does not return normally to caller.");
> 
> I think that is caused by my patch and the fix seems to simply add the _
> as attached. OK to push?

Sorry, forgot to attach. Now it is.

> How do I run these ARI checks locally? And could the buildbot do them?
> 
> Thanks,
> 
> Mark
From 0ad193d0a8b80fbf32717ee7f88288f7552b12de Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Sat, 24 Jan 2015 15:08:32 +0100
Subject: [PATCH] Fix ARI warning in stack.c (return_command).

gdb/ChangeLog

    * stack.c (return_command): Markup warning message with _.
---
 gdb/ChangeLog | 4 ++++
 gdb/stack.c   | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Yao Qi Jan. 26, 2015, 10:51 a.m. UTC | #1 
On 01/24/2015 10:15 PM, Mark Wielaard wrote:
> Subject: [PATCH] Fix ARI warning in stack.c (return_command).
> 
> gdb/ChangeLog
> 
>     * stack.c (return_command): Markup warning message with _.

It is OK as the change is obvious.

--
Yao
Mark Wielaard Jan. 26, 2015, 11:42 a.m. UTC | #2 
On Mon, Jan 26, 2015 at 06:51:20PM +0800, Yao Qi wrote:
> On 01/24/2015 10:15 PM, Mark Wielaard wrote:
> > Subject: [PATCH] Fix ARI warning in stack.c (return_command).
> > 
> > gdb/ChangeLog
> > 
> >     * stack.c (return_command): Markup warning message with _.
> 
> It is OK as the change is obvious.

Thanks, pushed.

I hadn't pushed yet because I didn't know which build target to run
locally to check the ARI warning was fixed.

Cheers,

Mark
Yao Qi Jan. 26, 2015, 1:02 p.m. UTC | #3 
On 01/26/2015 07:42 PM, Mark Wielaard wrote:
> I hadn't pushed yet because I didn't know which build target to run
> locally to check the ARI warning was fixed.

I don't know how to run ARI through make either, but we can run ARI
script in local machine like this:

$ bash ./contrib/ari/gdb_ari.sh -Wall -Werror stack.c
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 10c3855..6b89515 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-01-24  Mark Wielaard  <mjw@redhat.com>
+
+	* stack.c (return_command): Markup warning message with _.
+
 2015-01-23  Simon Marchi  <simon.marchi@ericsson.com>
 
 	PR gdb/17416
diff --git a/gdb/stack.c b/gdb/stack.c
index 5f2a3dc..5831999 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -2464,7 +2464,7 @@  return_command (char *retval_exp, int from_tty)
       else
 	{
 	  if (TYPE_NO_RETURN (thisfun->type))
-	    warning ("Function does not return normally to caller.");
+	    warning (_("Function does not return normally to caller."));
 	  confirmed = query (_("%sMake %s return now? "), query_prefix,
 			     SYMBOL_PRINT_NAME (thisfun));
 	}