From patchwork Thu Jan 22 18:34:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 4761 Received: (qmail 27313 invoked by alias); 22 Jan 2015 18:36:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27122 invoked by uid 89); 22 Jan 2015 18:35:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Jan 2015 18:34:28 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MIYQMU021605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Jan 2015 13:34:26 -0500 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0MIYM1t031770 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 22 Jan 2015 13:34:24 -0500 Date: Thu, 22 Jan 2015 19:34:21 +0100 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches Subject: [commit] [patch] Print current thread after loading a core file [Re: [patch] Sort threads for thread apply all (bt)] Message-ID: <20150122183421.GA14827@host2.jankratochvil.net> References: <20150115183316.GA16405@host2.jankratochvil.net> <20150117205934.GA31682@host2.jankratochvil.net> <21696.17946.241321.820985@ruffy2.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <21696.17946.241321.820985@ruffy2.mtv.corp.google.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Thu, 22 Jan 2015 01:36:42 +0100, Doug Evans wrote: > Jan Kratochvil writes: > > + /* Current thread should be NUM 1 but the user does not know that. */ > > + if (thread_count () >= 2) > > Can you add a comment explaining why the test is >= 2 here? > E.g., something like > > /* Current thread should be NUM 1 but the user does not know that. > If a program is single threaded gdb in general does not mention > anything about threads. That is why the test is >= 2. */ Done. > LGTM with one nit. Checked in. Thanks, Jan downstream Fedora request: Please make it easier to find the backtrace of the crashing thread https://bugzilla.redhat.com/show_bug.cgi?id=1024504 Currently after loading a core file GDB prints: Core was generated by `./threadcrash1'. Program terminated with signal SIGSEGV, Segmentation fault. 8 *(volatile int *)0=0; (gdb) _ there is nowhere seen which of the threads had crashed. In reality GDB always numbers that thread as #1 and it is the current thread that time. But after dumping all the info into a file for later analysis it is no longer obvious. 'thread apply all bt' even puts the thread #1 to the _end_ of the output!!! Should GDB always print after loading a core file what "thread" command would print? [Current thread is 1 (Thread 0x7fcbe28fe700 (LWP 15453))] BTW I think it will print the thread even when loading single/non-threaded core file when other inferior(s) exist. But that currently crashes [Bug threads/12074] multi-inferior internal error https://sourceware.org/bugzilla/show_bug.cgi?id=12074 plus I think that would be a correct behavior anyway. gdb/ChangeLog 2015-01-22 Jan Kratochvil * corelow.c (core_open): Call also thread_command. * gdbthread.h (thread_command): New prototype moved from ... * thread.c (thread_command): ... here. (thread_command): Make it global. --- gdb/ChangeLog | 7 +++++++ gdb/corelow.c | 13 +++++++++++++ gdb/gdbthread.h | 2 ++ gdb/thread.c | 3 +-- 4 files changed, 23 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a6ba992..dfb9c90 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2015-01-22 Jan Kratochvil + + * corelow.c (core_open): Call also thread_command. + * gdbthread.h (thread_command): New prototype moved from ... + * thread.c (thread_command): ... here. + (thread_command): Make it global. + 2015-01-22 Eli Zaretskii * gdb/tui/tui.c (tui_enable) [__MINGW32__]: If the call to 'newterm' diff --git a/gdb/corelow.c b/gdb/corelow.c index a9eadd5..6a67a98 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -456,6 +456,19 @@ core_open (const char *arg, int from_tty) /* Now, set up the frame cache, and print the top of stack. */ reinit_frame_cache (); print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1); + + /* Current thread should be NUM 1 but the user does not know that. + If a program is single threaded gdb in general does not mention + anything about threads. That is why the test is >= 2. */ + if (thread_count () >= 2) + { + TRY_CATCH (except, RETURN_MASK_ERROR) + { + thread_command (NULL, from_tty); + } + if (except.reason < 0) + exception_print (gdb_stderr, except); + } } static void diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index 15a979b..a2f378a 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -455,6 +455,8 @@ extern void finish_thread_state_cleanup (void *ptid_p); /* Commands with a prefix of `thread'. */ extern struct cmd_list_element *thread_cmd_list; +extern void thread_command (char *tidstr, int from_tty); + /* Print notices on thread events (attach, detach, etc.), set with `set print thread-events'. */ extern int print_thread_events; diff --git a/gdb/thread.c b/gdb/thread.c index ed20fbe..4bce212 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -62,7 +62,6 @@ static int highest_thread_num; spawned new threads we haven't heard of yet. */ static int threads_executing; -static void thread_command (char *tidstr, int from_tty); static void thread_apply_all_command (char *, int); static int thread_alive (struct thread_info *); static void info_threads_command (char *, int); @@ -1506,7 +1505,7 @@ thread_apply_command (char *tidlist, int from_tty) /* Switch to the specified thread. Will dispatch off to thread_apply_command if prefix of arg is `apply'. */ -static void +void thread_command (char *tidstr, int from_tty) { if (!tidstr)