From patchwork Wed Jan  7 14:38:20 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jan Kratochvil <jan.kratochvil@redhat.com>
X-Patchwork-Id: 4547
Received: (qmail 15500 invoked by alias); 7 Jan 2015 14:38:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 15486 invoked by uid 89); 7 Jan 2015 14:38:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL, BAYES_00,
	SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by
	sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with
	(AES256-GCM-SHA384 encrypted) ESMTPS;
	Wed, 07 Jan 2015 14:38:28 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by
	mx1.redhat.com (8.14.4/8.14.4) with ESMTP id
	t07EcOQG015649	(version=TLSv1/SSLv3
	cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);
	Wed, 7 Jan 2015 09:38:25 -0500
Received: from host2.jankratochvil.net (ovpn-116-60.ams2.redhat.com
	[10.36.116.60])	by int-mx09.intmail.prod.int.phx2.redhat.com
	(8.14.4/8.14.4) with ESMTP id
	t07EcKN3022491	(version=TLSv1/SSLv3 cipher=AES128-SHA
	bits=128 verify=NO); Wed, 7 Jan 2015 09:38:23 -0500
Date: Wed, 7 Jan 2015 15:38:20 +0100
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Sasha Smundak <asmundak@google.com>
Subject: [testsuite patch] Fix new FAIL: py-frame.exp: test
	Frame.read_register(rip)
Message-ID: <20150107143820.GA1482@host2.jankratochvil.net>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes

Hi,

for x86_64 -m32 run one gets:

+FAIL: gdb.python/py-frame.exp: test Frame.read_register(rip)

I do not have x32 OS here but the %rip test should PASS there I think.

OK for check-in?

The code is there since:
	commit 5f3b99cfed3803f0b099152f54aac7cb90a2b926
	Author: Sasha Smundak <asmundak@google.com>
	Date:   Wed Sep 3 16:34:47 2014 -0700
	    Add support for reading frame registers to Python API.


Jan
gdb/testsuite/
2015-01-07  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.python/py-frame.exp (test Frame.read_register(rip)): Use
	is_amd64_regs_target.

diff --git a/gdb/testsuite/gdb.python/py-frame.exp b/gdb/testsuite/gdb.python/py-frame.exp
index bf2e1ce..984acfc 100644
--- a/gdb/testsuite/gdb.python/py-frame.exp
+++ b/gdb/testsuite/gdb.python/py-frame.exp
@@ -106,7 +106,7 @@ gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.pc()))" \
   "test Frame.read_register(pc)"
 
 # On x86-64, PC is in $rip register.
-if {[istarget x86_64-*]} {
+if {[is_amd64_regs_target]} {
     gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('rip')))" \
 	" = True" \
 	"test Frame.read_register(rip)"