Message ID | 20141208223958.4de115f7@arch |
---|---|
State | New, archived |
Headers |
Received: (qmail 14172 invoked by alias); 8 Dec 2014 22:39:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 14156 invoked by uid 89); 8 Dec 2014 22:39:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.9 required=5.0 tests=AWL, BAYES_40, KAM_COUK, RCVD_IN_DNSWL_NONE, SPF_FAIL, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: relay.mailchannels.net Received: from si-002-i157.relay.mailchannels.net (HELO relay.mailchannels.net) (108.178.49.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Dec 2014 22:38:59 +0000 X-Sender-Id: wwwh|x-authuser|alastair@ajor.co.uk Received: from s8-london.accountservergroup.com (ip-10-213-14-133.us-west-2.compute.internal [10.213.14.133]) by relay.mailchannels.net (Postfix) with ESMTPA id D2DCB60679 for <gdb-patches@sourceware.org>; Mon, 8 Dec 2014 22:38:51 +0000 (UTC) X-Sender-Id: wwwh|x-authuser|alastair@ajor.co.uk Received: from s8-london.accountservergroup.com (s8-london.accountservergroup.com [10.253.8.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.2); Mon, 08 Dec 2014 22:38:52 GMT X-MC-Relay: Neutral X-MailChannels-SenderId: wwwh|x-authuser|alastair@ajor.co.uk X-MailChannels-Auth-Id: wwwh X-MC-Loop-Signature: 1418078332202:1515968424 X-MC-Ingress-Time: 1418078332202 Received: from cpc2-acto2-2-0-cust33.4-2.cable.virginm.net ([86.1.72.34]:58841 helo=arch) by s8-london.accountservergroup.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.82) (envelope-from <alastair@ajor.co.uk>) id 1Xy6x8-0006YV-1J for gdb-patches@sourceware.org; Mon, 08 Dec 2014 22:38:50 +0000 Date: Mon, 8 Dec 2014 22:39:58 +0000 From: Alastair Robertson <alastair@ajor.co.uk> To: gdb-patches@sourceware.org Subject: [PATCH] Printing of large objects not interruptable Message-ID: <20141208223958.4de115f7@arch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AuthUser: alastair@ajor.co.uk X-IsSubscribed: yes |
Commit Message
Alastair Robertson
Dec. 8, 2014, 10:39 p.m. UTC
This patch makes the counting of repeated characters interruptable, relating to bug 17613 https://sourceware.org/bugzilla/show_bug.cgi?id=17613 This is my first patch, so sorry if I forgot to include something or didn't format it correctly. 2014-12-07 Alastair Robertson <alastair@ajor.co.uk> PR gdb/17613 * valprint.c (count_next_character): Call QUIT
Comments
> This patch makes the counting of repeated characters interruptable, > relating to bug 17613 > https://sourceware.org/bugzilla/show_bug.cgi?id=17613 > > This is my first patch, so sorry if I forgot to include something or > didn't format it correctly. > > 2014-12-07 Alastair Robertson <alastair@ajor.co.uk> > > PR gdb/17613 > * valprint.c (count_next_character): Call QUIT This patch looks good to me. If you could add a short description of what this PR is about in the commit's revision log, so as to avoid the need to go through a PR, which is not always a straightforward (or even concise read), that would be very good. In terms of items for submission, we have a checklist: https://sourceware.org/gdb/wiki/ContributionChecklist There is a lot of important information there, if you haven't read it yet. As far as this patch is concerned, the only bits that are missing are a period at the end of your sentence in your ChangeLog entry; and an indication that you ran the testsuite before and after your patch, showing no regression (this one is unlikely to produce any, but better safe than sorry) - that indication should be in the commit's revision log, including the platform that was used to perform the testing. Please re-send an updated patch, and I will push it for you. Thank you! > diff --git a/gdb/valprint.c b/gdb/valprint.c > index b995304..8d743b1 100644 > --- a/gdb/valprint.c > +++ b/gdb/valprint.c > @@ -2151,6 +2151,8 @@ count_next_character (struct wchar_iterator *iter, > > while (1) > { > + QUIT; > + > /* Get the next character. */ > d.num_chars > = wchar_iterate (iter, &d.result, &chars, &d.buf, &d.buflen);
diff --git a/gdb/valprint.c b/gdb/valprint.c index b995304..8d743b1 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2151,6 +2151,8 @@ count_next_character (struct wchar_iterator *iter, while (1) { + QUIT; + /* Get the next character. */ d.num_chars = wchar_iterate (iter, &d.result, &chars, &d.buf, &d.buflen);