From patchwork Wed Sep 10 13:14:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 2747 Received: (qmail 24556 invoked by alias); 10 Sep 2014 13:14:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 24545 invoked by uid 89); 10 Sep 2014 13:14:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 10 Sep 2014 13:14:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 524391165AD; Wed, 10 Sep 2014 09:14:08 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lmEIoLFtcF2D; Wed, 10 Sep 2014 09:14:08 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 213CC1161D3; Wed, 10 Sep 2014 09:14:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 62030477FF; Wed, 10 Sep 2014 06:14:10 -0700 (PDT) Date: Wed, 10 Sep 2014 06:14:10 -0700 From: Joel Brobecker To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [pushed] Fix missing "struct iovec" definition on some x86-linux. (was: "[PATCH 7/7 v2] Tidy #include lists") Message-ID: <20140910131410.GA26248@adacore.com> References: <1403878351-22974-1-git-send-email-gbenson@redhat.com> <1403878351-22974-8-git-send-email-gbenson@redhat.com> <20140909150904.GA24918@adacore.com> <20140910105903.GA30066@blade.nx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140910105903.GA30066@blade.nx> User-Agent: Mutt/1.5.21 (2010-09-15) > > > This commit tidies up the #include lists in {i386,amd64}-linux-nat.c, > > > removing headers that are no longer required and reordering some > > > lines so that both files roughly match. Additionally, an unused > > > definition was removed from the middle of the #include list in > > > i386-linux-nat.c. > > > > Unfortunately, this patch broke GDB builds on some GNU/Linux > > distros. I fixed the issue I got by applying the attached patch. > > Thanks for fixing this Joel. Of course! As it happens, we need to do the same for amd64-linux-nat.c as well. It makes sense, not sure why I didn't think of that before. Attached is the patch I just pushed. gdb/ChangeLog: * amd64-linux-nat.c: Add #include. From 35782f1465dd014737fcf6c82bdf733598a5c9b8 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 10 Sep 2014 09:06:50 -0400 Subject: [PATCH] Add #include back in amd64-linux-nat.c. This include is needed to access the definition of "struct iovec". gdb/ChangeLog: * amd64-linux-nat.c: Add #include. --- gdb/ChangeLog | 4 ++++ gdb/amd64-linux-nat.c | 1 + 2 files changed, 5 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 93a3931..2d20b1c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-09-10 Joel Brobecker + + * amd64-linux-nat.c: Add #include. + 2014-09-09 Doug Evans PR guile/17367 diff --git a/gdb/amd64-linux-nat.c b/gdb/amd64-linux-nat.c index a00fbd6..09a4dfd 100644 --- a/gdb/amd64-linux-nat.c +++ b/gdb/amd64-linux-nat.c @@ -22,6 +22,7 @@ #include "inferior.h" #include "regcache.h" #include "elf/common.h" +#include #include #include #include -- 1.9.1