From patchwork Wed Aug 13 18:26:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 2391 Received: (qmail 32546 invoked by alias); 13 Aug 2014 18:26:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 32529 invoked by uid 89); 13 Aug 2014 18:26:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 13 Aug 2014 18:26:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 12B741163FB; Wed, 13 Aug 2014 14:26:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EIAwZNw4pY-X; Wed, 13 Aug 2014 14:26:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DC2941163F9; Wed, 13 Aug 2014 14:26:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 05025493BC; Wed, 13 Aug 2014 11:26:56 -0700 (PDT) Date: Wed, 13 Aug 2014 11:26:55 -0700 From: Joel Brobecker To: Eli Zaretskii Cc: yao@codesourcery.com, gdb-patches@sourceware.org Subject: Re: Warnings in native MinGW32 build of GDB 7.8 Message-ID: <20140813182655.GH4881@adacore.com> References: <83r40plpp3.fsf@gnu.org> <53EAE47A.6030700@codesourcery.com> <83k36cifeq.fsf@gnu.org> <20140813174227.GF4881@adacore.com> <83d2c4i7y2.fsf@gnu.org> <20140813181033.GG4881@adacore.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140813181033.GG4881@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) > > I can do the 1st and the 3rd parts, but I'd prefer not to touch > > gdbarch.sh. Could one of you please do that? Attached is a patch that does that. Can you confirm it fixes your warnings? From ee8948e61a8047d67cf8ad32d3259dbe7951a527 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 13 Aug 2014 11:15:00 -0700 Subject: [PATCH] Add "frame.h" #include in gdbarch.h. This include is needed because of gdbarch_dummy_id needs the full definition of struct frame_id. gdb/ChangeLog: * gdbarch.sh: #include "frame.h" in gdbarch.h. Delete "struct frame_info" advance declaration. Tested on x86_64-linux by rebuilding GDB. --- gdb/gdbarch.h | 3 ++- gdb/gdbarch.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 5388e6e..0303b2e 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -35,9 +35,10 @@ #ifndef GDBARCH_H #define GDBARCH_H +#include "frame.h" + struct floatformat; struct ui_file; -struct frame_info; struct value; struct objfile; struct obj_section; diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 61d0781..2a8bca8 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -1124,9 +1124,10 @@ cat <