From patchwork Sun Jun 22 21:14:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 1652 Received: (qmail 5126 invoked by alias); 22 Jun 2014 21:14:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5115 invoked by uid 89); 22 Jun 2014 21:14:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 22 Jun 2014 21:14:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5MLE6Tg012267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 22 Jun 2014 17:14:06 -0400 Received: from host2.jankratochvil.net (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5MLE1WI016836 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Sun, 22 Jun 2014 17:14:04 -0400 Date: Sun, 22 Jun 2014 23:14:01 +0200 From: Jan Kratochvil To: Sergio Durigan Junior Cc: Mark Kettenis , gdb-patches@sourceware.org, brobecker@adacore.com Subject: [testsuite patch+7.8] gdb.arch/amd64-stap-special-operands.exp !is_lp64_target [Re: [PATCH] Fix for PR tdep/16397: SystemTap SDT probe support for x86 doesn't work with "triplet operands"] Message-ID: <20140622211401.GA3716@host2.jankratochvil.net> References: <201401301535.s0UFZp3N013895@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Thu, 20 Feb 2014 22:53:21 +0100, Sergio Durigan Junior wrote: > Thanks, I finally pushed it with the necessary fixes. > https://sourceware.org/ml/gdb-cvs/2014-02/msg00106.html # if { ![istarget "x86_64-*-*"] && ![istarget "i?86-*-*"] } { # verbose "Skipping amd64-stap-special-operands.exp" # return # } On x86_64 with -m32 or on i686 it will: Running ./gdb.arch/amd64-stap-special-operands.exp ... gdb compile failed, amd64-stap-triplet.c: Assembler messages: amd64-stap-triplet.c:35: Error: bad register name `%rbp' amd64-stap-triplet.c:38: Error: bad register name `%rsp' amd64-stap-triplet.c:40: Error: bad register name `%rbp)' amd64-stap-triplet.c:41: Error: bad register name `%rsi' amd64-stap-triplet.c:42: Error: bad register name `%rbp)' /tmp/ccjOdmpl.s:63: Error: bad register name `%rbp' IMO there should be the patch below. OK for check-in? It would apply as [obv] but I rather ask Sergio if it was meant this way. Jan gdb/testsuite/ 2014-06-22 Jan Kratochvil * gdb.arch/amd64-stap-special-operands.exp: Use is_lp64_target. diff --git a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp index a6ce7f5..988b5d6 100644 --- a/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp +++ b/gdb/testsuite/gdb.arch/amd64-stap-special-operands.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -if { ![istarget "x86_64-*-*"] && ![istarget "i?86-*-*"] } { +if { ![istarget "x86_64-*-*"] || ![is_lp64_target] } { verbose "Skipping amd64-stap-special-operands.exp" return }