From patchwork Fri Jun 20 12:01:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Benson X-Patchwork-Id: 1593 Received: (qmail 20287 invoked by alias); 20 Jun 2014 12:01:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20272 invoked by uid 89); 20 Jun 2014 12:01:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Jun 2014 12:01:52 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5KC1oE3019625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 20 Jun 2014 08:01:51 -0400 Received: from blade.nx (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5KC1oiV018703; Fri, 20 Jun 2014 08:01:50 -0400 Received: by blade.nx (Postfix, from userid 1000) id 7FC0D2624A1; Fri, 20 Jun 2014 13:01:49 +0100 (BST) Date: Fri, 20 Jun 2014 13:01:49 +0100 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC 0/2] let gdbserver use libiberty Message-ID: <20140620120149.GA9199@blade.nx> References: <1390243792-31176-1-git-send-email-tromey@redhat.com> <87oaxxrhj4.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87oaxxrhj4.fsf@fleche.redhat.com> X-IsSubscribed: yes Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > Tom> This series changes gdbserver to build its own copy of libiberty > Tom> (using ACX_CONFIGURE_DIR) and then link against it. I've needed > Tom> this at least once (for a cloexec patch) and I've seen other > Tom> situations where it would have been useful. > > This series slipped through the cracks somehow. I'm going to push > it now. I believe I addressed all the review comments upthread. I > rebased it and rebuilt it on x86-64 Fedora 20; let me know if you > encounter any problems. I had to apply the attached patch (and run autoconf, autoheader) to build with mingw32 on x86-64 RHEL 6.5. Should I tidy this up and commit it? Cheers Gary diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index ede38d0..6fb2379 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -85,7 +85,6 @@ AC_CHECK_HEADERS(sgtty.h termio.h termios.h sys/reg.h string.h dnl sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl netinet/tcp.h arpa/inet.h) AC_CHECK_FUNCS(pread pwrite pread64 readlink) -AC_REPLACE_FUNCS(vasprintf vsnprintf) GDB_AC_COMMON