From patchwork Thu Oct 16 09:07:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Kumar Agarwal X-Patchwork-Id: 3243 Received: (qmail 29272 invoked by alias); 16 Oct 2014 09:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29261 invoked by uid 89); 16 Oct 2014 09:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2on0060.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.100.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 09:07:59 +0000 Received: from BY2FFO11FD025.protection.gbl (10.1.14.33) by BY2FFO11HUB006.protection.gbl (10.1.14.164) with Microsoft SMTP Server (TLS) id 15.0.1039.16; Thu, 16 Oct 2014 09:07:56 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BY2FFO11FD025.mail.protection.outlook.com (10.1.15.214) with Microsoft SMTP Server (TLS) id 15.0.1039.16 via Frontend Transport; Thu, 16 Oct 2014 09:07:56 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1Xeh0W-0004eO-9W; Thu, 16 Oct 2014 02:06:04 -0700 From: Ajit Kumar Agarwal To: Pedro Alves , "gdb-patches@sourceware.org" CC: Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [PATCH] Microblaze: Replace microblaze-expedite from pc to rpc. Date: Thu, 16 Oct 2014 09:07:36 +0000 References: <834b5a4a6940422b95f7e1e50b5d1bec@BY2FFO11FD033.protection.gbl> <543E8D67.2050604@redhat.com> In-Reply-To: <543E8D67.2050604@redhat.com> MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <187ed9e5981f49eb8b25805d95e1346c@BY2FFO11FD025.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(438002)(51704005)(199003)(479174003)(377454003)(24454002)(377424004)(189002)(13464003)(54534003)(76482002)(47776003)(20776003)(46102003)(80022003)(95666004)(64706001)(87936001)(97756001)(2656002)(6806004)(19580405001)(44976005)(19580395003)(85306004)(108616004)(77096002)(104016003)(106116001)(106466001)(53416004)(99396003)(4396001)(107046002)(120916001)(21056001)(23726002)(54356999)(76176999)(50986999)(31966008)(575784001)(46406003)(92566001)(86362001)(85852003)(74316001)(50466002)(107986001)(24736002)(23106004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2FFO11HUB006; H:xsj-pvapsmtpgw01; FPR:; MLV:sfv; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB006; X-Exchange-Antispam-Report-Test: UriScan:; X-Forefront-PRVS: 036614DD9C Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-OriginatorOrg: xilinx.com -----Original Message----- From: Pedro Alves [mailto:palves@redhat.com] Sent: Wednesday, October 15, 2014 8:36 PM To: Ajit Kumar Agarwal; gdb-patches@sourceware.org Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [PATCH] Microblaze: Replace microblaze-expedite from pc to rpc. On 10/13/2014 10:15 AM, Ajit Kumar Agarwal wrote: > Please find the patch below based on Pedro suggestions. > > Microblaze: Replace microblaze-expedite from pc to rpc. > > Replace microblaze-expedite from pc to rpc. The makefile and > the following commands are used to create microblaze-with-stack-protect.dat. >>I'd like it that the commit log mentions _why_ this was necessary. > > make ../regformats/microblaze-with-stack-protect.dat > > gdb/ > 2014-10-13 Ajit Agarwal > > * features/Makefile (microblaze-expedite): Replace > microblaze-expediate from pc to rpc. >>typo: "expediate", but, the ()'s bit already gave the context. > * regformats/microblaze-with-stack-protect.dat: Created > using Makefile. >>Please present tense. Thanks Pedro for the suggestions. >>I've fixed up these issues for you and pushed the patch as below. >>gdb/features/microblaze.dat has the same problem... But, AFAICS, your GDBserver port doesn't use that file, I'll just delete it. Thanks Pedro for pushing in the patch. >>Is there no way GDBserver could tell whether the machine has the stack protect registers? Microblaze Linux Kernel doesn't have support for this like other Architectures. If permissible would like to incorporate this feature in gdbserver later once the Kernel support for this is done. In the meanwhile Can we goahead with this gdbserver patch if permissible. ------- From 449aa9dfd1505925a4a5dfff470f24a17699b5bc Mon Sep 17 00:00:00 2001 From: Ajit Kumar Agarwal Date: Mon, 13 Oct 2014 14:28:22 +0530 Subject: [PATCH] Microblaze: Replace microblaze-expedite from pc to rpc The Microblaze PC register is called "rpc", not "pc", as can be seen in microblaze-core.xml. Fix this, so GDBserver can find the register in the regcache. gdb/ 2014-10-15 Ajit Agarwal * features/Makefile (microblaze-expedite): Replace pc with rpc. * regformats/microblaze-with-stack-protect.dat: Regenerate. --- gdb/ChangeLog | 5 +++++ gdb/features/Makefile | 2 +- gdb/regformats/microblaze-with-stack-protect.dat | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) xmltarget:microblaze-with-stack-protect.xml -expedite:r1,pc +expedite:r1,rpc 32:r0 32:r1 32:r2 -- 1.9.3 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c4f0437..0d22b51 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-10-15 Ajit Agarwal + + * features/Makefile (microblaze-expedite): Replace pc with rpc. + * regformats/microblaze-with-stack-protect.dat: Regenerate. + 2014-10-15 Siva Chandra Reddy * gnu-v3-abi.c (gnuv3_pass_by_reference): Treat dynamic classes diff --git a/gdb/features/Makefile b/gdb/features/Makefile index c17157b..7708f5b 100644 --- a/gdb/features/Makefile +++ b/gdb/features/Makefile @@ -103,7 +103,7 @@ mips-expedite = r29,pc mips-dsp-expedite = r29,pc mips64-expedite = r29,pc mips64-dsp-expedite = r29,pc -microblaze-expedite = r1,pc +microblaze-expedite = r1,rpc nios2-linux-expedite = sp,pc powerpc-expedite = r1,pc rs6000/powerpc-cell32l-expedite = r1,pc,r0,orig_r3,r4 diff --git a/gdb/regformats/microblaze-with-stack-protect.dat b/gdb/regformats/microblaze-with-stack-protect.dat index 5ce0c24..8040a7b 100644 --- a/gdb/regformats/microblaze-with-stack-protect.dat +++ b/gdb/regformats/microblaze-with-stack-protect.dat @@ -2,7 +2,7 @@ # Generated from: microblaze-with-stack-protect.xml name:microblaze_with_stack_protect