From patchwork Mon Feb 27 21:29:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65705 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06CFC385021F for ; Mon, 27 Feb 2023 21:30:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06CFC385021F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677533431; bh=rCsBIweGUmy2WsQ9Qgz5XNbQOLhP1qfxrnegdHlNwJ4=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SA2TyDj4pIaRh3SowhTJGyrzVp5xR57rG+zN/jivtf7CaRgFAp2kmHuqI5qk8AmIV Ya2PjdnOtPr/BfYBz4FaWAmw3ccSpKze7QsKglD79xxU5QQcGhFjiq8nd+gd/vjXxK CxZnbtSoi2ugFSxR5J+BuEy8SE9gHppwfuhqnP0Y= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 85F0E3858D39 for ; Mon, 27 Feb 2023 21:29:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85F0E3858D39 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-397-g-p3sGB9NsmeYjsJfVTTNA-1; Mon, 27 Feb 2023 16:29:32 -0500 X-MC-Unique: g-p3sGB9NsmeYjsJfVTTNA-1 Received: by mail-wm1-f71.google.com with SMTP id e22-20020a05600c219600b003e000facbb1so5908517wme.9 for ; Mon, 27 Feb 2023 13:29:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677533371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rCsBIweGUmy2WsQ9Qgz5XNbQOLhP1qfxrnegdHlNwJ4=; b=olxAOtJ8RHPgaxDa3wh8tv0Y539mi3nDQajSh05oOeQKGguHF2d2YEPNCHmEEshhCQ BbpLr2bjNIloITHp3VdMx4YjhjHQNfJxVSkw9VQhowFL9E0OQnhbJtfJEBcbSk7R3c7q rB23jsYth7Y3mHgOLVveXaOjyzPOhJnifEX0ZXXnai4FV/2iCYBSHaX4rGAPpGnELL4H dsSMK2ibHWjDWVvt1mQEjfVmUTZv2AHqfQuwdvPuNLnKsmBJSI5+ATHbu0jxBCnFckae bR0lCWilVr0zmHi19eKtXnYcnqjMy31Ary1KkD2n93FPWJlwcEZpaQnU4D0vQBsad6Nu RF4w== X-Gm-Message-State: AO0yUKW3y5R1WzX2I8Ak4P+8xS15TA4qhK0Gl+enBWi5zMh54q6FCiIe NS0Y7rEu4dIOWL3HH7MDOxlvEJb40/2W4Q2yQwQWQEfC4ssLBUAOG+rA1hJYxyaKPTvo2+VC4n1 AGdazbW3Jnb+dRznWTnGEGo6mc/IAHyyJpxOOHzyliHsrJeIxR+A8CHisX88Ie/AXYr/8n6Bsmg qOwHM= X-Received: by 2002:a05:600c:3512:b0:3df:9858:c02e with SMTP id h18-20020a05600c351200b003df9858c02emr7701717wmq.3.1677533371390; Mon, 27 Feb 2023 13:29:31 -0800 (PST) X-Google-Smtp-Source: AK7set+ipKijmaseRe4u3dU+wbDrDkeYQBMYIlAsyxTtuq9JvYCWpgZv5w+gIlMmVEsd34pgpSfMNA== X-Received: by 2002:a05:600c:3512:b0:3df:9858:c02e with SMTP id h18-20020a05600c351200b003df9858c02emr7701703wmq.3.1677533371046; Mon, 27 Feb 2023 13:29:31 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id u26-20020a05600c441a00b003e21638c0edsm10583589wmn.45.2023.02.27.13.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 13:29:30 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 01/13] gdb: remove uses of alloca from arch-utils.c Date: Mon, 27 Feb 2023 21:29:14 +0000 Message-Id: <15cec6aaaad2f1147323b4dc5e13be69135d6889.1677533215.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Remove the two uses of alloca from arch-utils.c, replace them both with gdb::byte_vector instead. There should be no user visible changes after this commit. --- gdb/arch-utils.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c index e3af9ce2dbc..be90d0ed89c 100644 --- a/gdb/arch-utils.c +++ b/gdb/arch-utils.c @@ -933,7 +933,7 @@ default_program_breakpoint_here_p (struct gdbarch *gdbarch, if (bpoint == nullptr) return false; - gdb_byte *target_mem = (gdb_byte *) alloca (len); + gdb::byte_vector target_mem (len); /* Enable the automatic memory restoration from breakpoints while we read the memory. Otherwise we may find temporary breakpoints, ones @@ -941,11 +941,11 @@ default_program_breakpoint_here_p (struct gdbarch *gdbarch, scoped_restore restore_memory = make_scoped_restore_show_memory_breakpoints (0); - if (target_read_memory (address, target_mem, len) == 0) + if (target_read_memory (address, target_mem.data (), len) == 0) { /* Check if this is a breakpoint instruction for this architecture, including ones used by GDB. */ - if (memcmp (target_mem, bpoint, len) == 0) + if (memcmp (target_mem.data (), bpoint, len) == 0) return true; } @@ -1012,7 +1012,6 @@ default_guess_tracepoint_registers (struct gdbarch *gdbarch, CORE_ADDR addr) { int pc_regno = gdbarch_pc_regnum (gdbarch); - gdb_byte *regs; /* This guessing code below only works if the PC register isn't a pseudo-register. The value of a pseudo-register isn't stored @@ -1023,10 +1022,10 @@ default_guess_tracepoint_registers (struct gdbarch *gdbarch, if (pc_regno < 0 || pc_regno >= gdbarch_num_regs (gdbarch)) return; - regs = (gdb_byte *) alloca (register_size (gdbarch, pc_regno)); - store_unsigned_integer (regs, register_size (gdbarch, pc_regno), + gdb::byte_vector regs (register_size (gdbarch, pc_regno)); + store_unsigned_integer (regs.data (), register_size (gdbarch, pc_regno), gdbarch_byte_order (gdbarch), addr); - regcache->raw_supply (pc_regno, regs); + regcache->raw_supply (pc_regno, regs.data ()); } int