From patchwork Wed Jan 9 21:41:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Philippe Waroquiers X-Patchwork-Id: 31020 Received: (qmail 52289 invoked by alias); 9 Jan 2019 21:41:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 52178 invoked by uid 89); 9 Jan 2019 21:41:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailsec111.isp.belgacom.be Received: from mailsec111.isp.belgacom.be (HELO mailsec111.isp.belgacom.be) (195.238.20.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 21:41:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1547070093; x=1578606093; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=GzED5MYP3gopIUnWHsMrkGKYER3+QXpp1e3P/G3OlGw=; b=gJea59m3dOWBO79ObJejcaRW1ExgFiCNhIi2VMqbTFYGMbZvh+R0b1yV VVWowdTlO5STBx0r2v1PpuAq0kt5yQ==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2019 22:41:31 +0100 Message-ID: <1547070090.1500.8.camel@skynet.be> Subject: Re: NEWS entry for Changes to the "frame", "select-frame" ... From: Philippe Waroquiers To: Eli Zaretskii , Andrew Burgess Cc: gdb-patches@sourceware.org Date: Wed, 09 Jan 2019 22:41:30 +0100 In-Reply-To: <831s5p24bz.fsf@gnu.org> References: <1546634071.1926.16.camel@skynet.be> <20190106104636.GQ3456@embecosm.com> <831s5p24bz.fsf@gnu.org> Mime-Version: 1.0 X-IsSubscribed: yes On Sun, 2019-01-06 at 17:28 +0200, Eli Zaretskii wrote: > > Date: Sun, 6 Jan 2019 10:46:36 +0000 > > From: Andrew Burgess > > Cc: gdb-patches > > > > * Philippe Waroquiers [2019-01-04 21:34:31 +0100]: > > > > > The below paragraph is at an unusual place in NEWS, > > > as new and changed commands are normally documented in the sections > > > * New commands > > > or > > > * Changed commands. > > > > > > Maybe it should be reworded and moved to these 2 sections ? > > > > > > Philippe > > > > > > * Changes to the "frame", "select-frame", and "info frame" CLI > > >   commands.  These commands all now take a frame specification which > > >   is either a frame level, or one of the keywords 'level', 'address', > > >   'function', or 'view' followed by a parameter.  Selecting a frame by > > >   address, or viewing a frame outside the current backtrace now > > >   requires the use of a keyword.  Selecting a frame by level is > > >   unchanged.  The MI comment "-stack-select-frame" is unchanged. > > > > This is fine with me (as the original author), but you'll need a > > maintainer to OK the change too. > > I'm OK with moving this to the "Changed commands" section. > > Thanks. Thanks for the feedback. I pushed the below change. Philippe diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1c20afc8a8..2e9c2f2e5a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-01-09  Philippe Waroquiers   + +       * NEWS: Move the description of the changed "frame", "select-frame", +        and "info frame" commands to the Changed commands section. +  2019-01-09  Simon Marchi             * gdbtypes.c (check_stub_method_group): Remove handling of old diff --git a/gdb/NEWS b/gdb/NEWS index 14c859f8f6..eaef6aa384 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -30,14 +30,6 @@  * GDB in batch mode now exits with status 1 if the last command to be    executed failed.   -* Changes to the "frame", "select-frame", and "info frame" CLI -  commands.  These commands all now take a frame specification which -  is either a frame level, or one of the keywords 'level', 'address', -  'function', or 'view' followed by a parameter.  Selecting a frame by -  address, or viewing a frame outside the current backtrace now -  requires the use of a keyword.  Selecting a frame by level is -  unchanged.  The MI comment "-stack-select-frame" is unchanged. -  * The RISC-V target now supports target descriptions.    * System call catchpoints now support system call aliases on FreeBSD. @@ -106,6 +98,14 @@ info proc files    * Changed commands   +Changes to the "frame", "select-frame", and "info frame" CLI commands. +  These commands all now take a frame specification which +  is either a frame level, or one of the keywords 'level', 'address', +  'function', or 'view' followed by a parameter.  Selecting a frame by +  address, or viewing a frame outside the current backtrace now +  requires the use of a keyword.  Selecting a frame by level is +  unchanged.  The MI comment "-stack-select-frame" is unchanged. +  target remote FILENAME  target extended-remote FILENAME    If FILENAME is a Unix domain socket, GDB will attempt to connect