Remove unnecessary ternary operator in m32c-tdep.c
Commit Message
Bug 17816 pointed out a useless use of the ternary operator:
case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;
I believe that this is right. If size is 1, the instruction refers to
part of r0, while if size is 2, the instruction refers to the whole of
r0.
gdb/ChangeLog:
PR gdb/17816
* m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
operator.
---
gdb/m32c-tdep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, 20 Aug 2018 10:32:41 -0400
Simon Marchi <simon.marchi@ericsson.com> wrote:
> PR gdb/17816
> * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
> operator.
LGTM.
Kevin
On 2018-08-20 18:27, Kevin Buettner wrote:
> On Mon, 20 Aug 2018 10:32:41 -0400
> Simon Marchi <simon.marchi@ericsson.com> wrote:
>
>> PR gdb/17816
>> * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
>> operator.
>
> LGTM.
>
> Kevin
Thanks, pushed.
Simon
@@ -1236,7 +1236,7 @@ m32c_decode_srcdest4 (struct m32c_pv_state *st,
switch (code)
{
- case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;
+ case 0x0: sd.reg = &st->r0; break;
case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break;
case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break;
case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break;